not.throwError with regexp matching should only fail if an error is actually thrown#79
Open
christianalfoni wants to merge 3 commits into
Open
not.throwError with regexp matching should only fail if an error is actually thrown#79christianalfoni wants to merge 3 commits into
christianalfoni wants to merge 3 commits into
Conversation
added 2 commits
November 19, 2013 18:05
|
Can you please add a test case for this bug? |
Author
|
Aha, sorry, added test now :-) Do I have to create a new pull request or can you just grab it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We built our own error constructor for arguments passed to a function, ArgumentsError.
When we test our code we get a problem with expect(fn).to.not.throwError(/ArgumentsError/)
This is what happens:
I have added a verification that there actually is an error thrown before reverting the NOT flag, as the NOT flag should only be reverted on actual throws, as I see it. No errors, not.to.throwError should pass even with a regexp matcher :-)