Skip to content

feat(core): support MDX#3631

Open
elijah-potter wants to merge 2 commits into
masterfrom
mdx
Open

feat(core): support MDX#3631
elijah-potter wants to merge 2 commits into
masterfrom
mdx

Conversation

@elijah-potter

Copy link
Copy Markdown
Collaborator

Issues

Closes #2702

Description

This PR adds support for MDX by replacing the existing pulldown_cmark-based Markdown parser with one based on the markdown crate, which already supports MDX.

How Has This Been Tested?

Existing tests pass. I will be adding more tests that include MDX.

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@FoxxMD

FoxxMD commented Jun 25, 2026

Copy link
Copy Markdown

An easy win! It seems. Hoping this can get merged soon so I can start linting all my documentation 😄

@elijah-potter

Copy link
Copy Markdown
Collaborator Author

The problem we've encountered that's made this work difficult to merge, is that our fuzzer found several high-profile panic conditions in the upstream crate used by this PR (markdown). It doesn't seem maintained, which makes it a difficult dependency to add. I'm thinking through solutions, though. Hopefully, we can merge it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request to support MDX

2 participants