feat(core): support MDX#3631
Open
elijah-potter wants to merge 2 commits into
Open
Conversation
|
An easy win! It seems. Hoping this can get merged soon so I can start linting all my documentation 😄 |
Collaborator
Author
|
The problem we've encountered that's made this work difficult to merge, is that our fuzzer found several high-profile panic conditions in the upstream crate used by this PR (markdown). It doesn't seem maintained, which makes it a difficult dependency to add. I'm thinking through solutions, though. Hopefully, we can merge it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Closes #2702
Description
This PR adds support for MDX by replacing the existing
pulldown_cmark-based Markdown parser with one based on themarkdowncrate, which already supports MDX.How Has This Been Tested?
Existing tests pass. I will be adding more tests that include MDX.
AI Disclosure
Checklist