feat: till date→to date#3706
Open
hippietrail wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
"Till date" is a very common Indianism for "to date" in common English.
It's sometimes spelled with a single "l" or with an apostrophe at the beginning or end.
There are some phrases where it could be a false positive if just blindly flagged: "good till date" is used in finance and "valid till date" is used for a date when something expires.
Currently it is never flagged when the selected dialect is "Indian" but perhaps even in Indian English it's not always considered correct, in which case maybe there should be a setting as well, but I don't think that's possible yet.
How Has This Been Tested?
cargo testAI Disclosure
I used an online AI to get ideas for Rusty ways to check the preceding tokens to exit early.
If Your PR Implements or Enhances a Linter
Checklist