Skip to content

Commit 1dbe11d

Browse files
vianaswclaude
andcommitted
Backup: fix progress animation overlapping the page header (#47697)
* Backup: fix progress animation overlapping the page header The backup in-progress animation uses absolutely positioned images with translateY keyframes that move them upward. When the content column is short, these elements escape the container bounds and visually overlap the AdminPage header. Fix by adding overflow: hidden to .backup__animation so images are clipped to the container, and removing the unnecessary z-index: 4 that caused them to paint above the header. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Backup: clip animation at section-hero boundary instead of grid cell The previous overflow: hidden on .backup__animation clipped animation elements inside the gray section, making them disappear into a visible beige gap (wp-admin body background) between the content and header. Move overflow: hidden up to AdminSectionHero (.section-hero) so animation clips at the gray section edge — a clean visual boundary. Also add z-index: 1 to the AdminPage header so it always paints above page content. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6a58db1 commit 1dbe11d

5 files changed

Lines changed: 10 additions & 1 deletion

File tree

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: fixed
3+
4+
Add overflow hidden to AdminSectionHero and z-index to AdminPage header to prevent content from overlapping the page header.

projects/js-packages/components/components/admin-page/style.module.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
// JETPACK-1386
2222
:global(.admin-ui-page__header) {
2323
position: relative;
24+
z-index: 1;
2425
}
2526

2627
// Normalize admin headers: implementation of admin-ui needs to
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
.section-hero {
22
padding-top: 1px; // prevent margin collapse for interior sections
33
background: var(--jp-white-off);
4+
overflow: hidden;
45
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: fixed
3+
4+
Fix progress animation overlapping the page header by clipping animation overflow.

projects/packages/backup/src/js/components/backups-style.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@
160160
.backup__animation-el-3 {
161161
opacity: 0;
162162
position: absolute;
163-
z-index: 4;
164163
animation: animation-el-3 4s ease-in-out 0.8s infinite normal forwards;
165164
}
166165

0 commit comments

Comments
 (0)