Skip to content

Commit b7e00ef

Browse files
committed
Charts: Document leaderboard row-gap as a tokenization outlier
The leaderboard's bar rows use a compact bar + gap + bar rhythm (6px bar, 6px row-gap, 6px bar) that does not align to the WPDS dimension scale — the closest token (gap-sm = 8px) visibly breaks the balance between row spacing and bar thickness. Add a comment so the next person to look at this doesn't try to tokenize the value. Surfaced during the spacing/border tokenization pass for CHARTS-199.
1 parent 9c9857b commit b7e00ef

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

projects/js-packages/charts/src/charts/leaderboard-chart/leaderboard-chart.module.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
display: grid;
2222
align-items: center;
2323
grid-template-columns: 1fr;
24+
// Outlier: not tokenized. The leaderboard's compact bar + gap + bar
25+
// rhythm (6px bar, 6px row-gap, 6px bar) is intentional and does not
26+
// map to any WPDS dimension token — gap-sm (8px) breaks the visual
27+
// balance between the rows and the bars.
2428
row-gap: 6px;
2529
isolation: isolate;
2630

0 commit comments

Comments
 (0)