Skip to content

Commit e9bb25c

Browse files
vianaswclaude
andcommitted
Newsletter: Move admin notices and JITMs below page header (#47714)
* Newsletter: Move admin notices and JITMs below page header Move GlobalNotices to render before the form content instead of after it, and add a #jp-admin-notices container for JITM injection. This follows the same pattern established in PR #47558 for My Jetpack, Social, and Search. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Newsletter: Use CSS logical properties for JITM card margins Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add changelog for newsletter admin notices fix Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6d7111b commit e9bb25c

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: fixed
3+
4+
Move admin notices and JITMs below the page header instead of rendering inside it

projects/packages/newsletter/src/settings/index.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,12 @@ function NewsletterSettingsApp(): JSX.Element | null {
388388
'jetpack-newsletter'
389389
) }
390390
>
391+
<GlobalNotices />
392+
<Container horizontalSpacing={ 0 }>
393+
<Col>
394+
<div id="jp-admin-notices" className="newsletter-jitm-card" />
395+
</Col>
396+
</Container>
391397
<Container horizontalSpacing={ 3 }>
392398
<Col>
393399
<Stack gap="md" direction="column" className="newsletter-settings">
@@ -456,8 +462,6 @@ function NewsletterSettingsApp(): JSX.Element | null {
456462
</Stack>
457463
</Disabled>
458464
</Stack>
459-
460-
<GlobalNotices />
461465
</Col>
462466
</Container>
463467
</AdminPage>

projects/packages/newsletter/src/settings/style.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@
1010
text-align: right;
1111
}
1212

13+
.newsletter-jitm-card {
14+
15+
.jitm-card {
16+
margin-inline-end: 0;
17+
margin-block: 1.5rem;
18+
}
19+
}
20+
1321
.newsletter-settings {
1422
max-width: 660px; /* MSD and future JP settings pages are 660px wide */
1523
margin-inline: auto;

0 commit comments

Comments
 (0)