CLI: Make yargs args strict

[tbradsha]

Proposed changes

This one's a bit silly, but I was trying to use --with-deps instead of --deps when building, and it would happily build with no errors, but of course didn't build deps. By switching yargs to strict by default, it now shows the help page when there's an invalid arg passed.

Another common error is trying to use --filter with the test command, which isn't supported.

Some commands need option passthrough. Both composer and pnpm already override with .strict( false ). I added changelog and docker as well.

There's also docker, which can use --, but those are handled differently in argv._. It turns out docker also needs passthrough, as it does things like jetpack docker wp plugin --activate.

Note that strict mode doesn't like negative (no-*) options by default. I could have set boolean-negation and update the JS vars, but I decided to just define the positive options as hidden.

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Test various jetpack commands with valid and invalid flags, e.g.:

• jetpack build plugins/crm --deps: builds with deps
• jetpack build plugins/crm --with-deps: shows help
• jetpack pnpm --version: shows pnpm version
• jetpack composer --version: shows composer version
• jetpack test js packages/connection --filter=asdf: shows help
• jetpack docker phpunit jetpack -- --filter=Jetpack_Components_Test: runs filtered set of tests

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/tools/prevent_invalid_flags_in_cli branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/tools/prevent_invalid_flags_in_cli

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/tools/prevent_invalid_flags_in_cli

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[anomiex]

I wonder if jetpack changelog needs non-strict as well. Or else going through and declaring any missing options, such as --filename-auto-suffix for jetpack changelog add.

Other than that, LGTM.

[tbradsha]

I wonder if jetpack changelog needs non-strict as well

Good catch. validate has --files, write has --now, and squash has a bunch...let's make it not strict:

80c2d6e