chore: pin third-party GitHub Actions to commit SHAs#49337
Conversation
Tracking: DEVPROD-1072
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
anomiex
left a comment
There was a problem hiding this comment.
Except for the addition of a Dependabot configuration when we already use Renovate, this seems reasonable to do what it intends.
Whether what it intends is actually a useful thing versus mainly making more work for us to maintain, I'm not sure.
There was a problem hiding this comment.
We already use Renovate to update things. It would probably be better to make any necessary config changes there rather than adding a second bot.
tbradsha
left a comment
There was a problem hiding this comment.
Along with @anomiex's comment about using Renovate, it seems per the original issue is to update all such usages in the Automattic org. I notice several mirror repos are on that list, and those actions would need to updated here, not in the mirror repos directly.
Finally, I notice there are three additional workflows with third-party actions that were missed (the first one is used by many of the existing workflows and the latter two are pushed out to the mirror repos):
.github/actions/tool-setup/action.yml
.github/files/gh-npmjs-autopublisher/workflows/npmjs-autopublisher.yml
.github/files/gh-wp-svn-autopublish/workflows/wp-svn-autopublish.yml
Tracking: DEVPROD-1072 Remove the added Dependabot config because Jetpack already uses Renovate for GitHub Actions updates. Pin non-GitHub third-party refs in .github/actions/tool-setup/action.yml, which is a Jetpack-owned local action used by workflows.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
@anomiex @tbradsha Thank you both for your reviews! 🙏🏾 I pushed a follow-up. Removed Dependabot and checked the mirror workflow sources in I updated the PR body with the |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
tbradsha
left a comment
There was a problem hiding this comment.
Sorry, I improperly flagged two first-party ones. 😄 But now it looks good.
Pins third-party GitHub Actions in this repo to immutable commit SHAs.
Tracking: DEVPROD-1072
Summary
.github/workflows/*.yml.github/files/*/workflows/*.ymlcopied mirror workflow templates.github/actions/**/action.ymllocal composite action metadatamirror-.github,gh-autotagger,gh-autorelease,gh-wp-svn-autopublish,gh-npmjs-autopublisher, andgh-e2e. The only non-GitHub third-party action in those copied workflow templates ispeter-evans/repository-dispatch, which is pinned here.actions/*refs are left as tag refs; this pass is scoped to non-GitHub third-party actions..github/files/*/workflows/*.yml.Testing instructions
uses:refs are pinned to 40-character commit SHAs.Does this pull request change what data or activity we track or use?
No.
Verification commands