Skip to content

JITM: center .jitm-card with margin 16px auto (9px auto on mobile)#50648

Draft
enejb wants to merge 1 commit into
trunkfrom
update/jitm-card-margins
Draft

JITM: center .jitm-card with margin 16px auto (9px auto on mobile)#50648
enejb wants to merge 1 commit into
trunkfrom
update/jitm-card-margins

Conversation

@enejb

@enejb enejb commented Jul 18, 2026

Copy link
Copy Markdown
Member

Proposed changes

Updates the .jitm-card margin so the card is horizontally centered:

  • Base: margin: 16px auto; (was 48px 20px 0 auto)
  • Mobile (<480px): margin: 9px auto;

Values use the existing rem.convert() helper and the file's <480px breakpoint convention.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Open any Jetpack/Woo admin screen (or a screen where a JITM renders) with a JITM visible.
  • Confirm the .jitm-card is horizontally centered with a 16px top/bottom margin.
  • Narrow the viewport below 480px and confirm the vertical margin tightens to 9px, still centered.

Screenshots

Captured on a live Jurassic Ninja site on the Plugins screen (a generic admin page where the base .jitm-card rule applies with no per-context override). A test JITM was injected via filter. Computed margin: before 48px 20px 0 0after 16px auto (desktop), 9px auto (<480px).

Desktop (1440px)

Before After
before desktop after desktop

Mobile (390px)

Before After
before mobile after mobile

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/jitm-card-margins branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/jitm-card-margins
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/jitm-card-margins

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 18, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Jitm [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant