Skip to content

Quality: Potential ReDoS vulnerability in regex-based CSS function parsing #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quality: Potential ReDoS vulnerability in regex-based CSS function parsing #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lib/variables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,22 @@ const uniqueString = (string) => {
*/
export const replaceVariables = (el, value) => {

// find non-nested css function calls
// eg: rgb(...), drop-shadow(...)
const funcReg = /([a-z\-]+)\s*\(\s*([^\(\)]*?)\s*(?:,\s*([^\(\)]*?)\s*)?\s*\)/i;
const replacements = [];
let match;
const uniq = uniqueString(value);
let funcReg = /([a-z\-]+)\s*\(\s*([^,\(\)]*)\s*(?:,\s*([^,\(\)]*)\s*)?\)/i;
let match;

while ((match = funcReg.exec(value)) !== null) {
const i = `${replacements.length}`;

// attempt to resolve variables
if (match[1].toLowerCase() == 'var') {
const varValue = findVariableValue(el, match[2]);

// found variable value
if (varValue) {
value = value.replace(match[0], varValue);
continue;
}

// use default value
// var(--name , default-value)
if (match[3]) {
value = value.replace(match[0], match[3]);
continue;
Expand Down