host/vitest: migrate off removed test.poolOptions for Vitest 4#826
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
Vitest 4.1.9 removed `test.poolOptions` (former pool options are now top-level), so `cd host && npx vitest run` printed a DEPRECATED warning on every run. Move `poolOptions.forks.maxForks` to the top-level `maxWorkers` (https://vitest.dev/guide/migration#pool-rework), keeping `pool: "forks"` and the CI=1 / local=4 worker cap. Refresh the stale comments that referenced vitest 3.2.4 and a pending 3.2.5+ fix. Verified against vitest 4.1.9: no poolOptions deprecation warning (CI and non-CI) and resolved config is pool=forks with maxWorkers=1 under CI / 4 locally, preserving prior maxForks behavior. Evidence under test-runs/kd-wgzh/. Bead: kd-wgzh Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
brandonpayton
deleted the
gascity/kd-1mr/kd-wgzh-migrate-vitest.config.ts-off-removed-test.pooloptions-fo
branch
July 13, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate
host/vitest.config.tsofftest.poolOptions, which Vitest 4 removed(the dev shell now installs Vitest 4.1.9). The former
poolOptions.forks.maxForksbecomes the top-level
maxWorkers;pool: "forks"andteardownTimeoutare unchanged.Stale comments referencing
vitest 3.2.4/ a pending3.2.5+fix are refreshed.Before this change every
cd host && npx vitest runprinted:Change
Behavior is preserved: with
pool: "forks",maxWorkerscaps the number of workerforks — 1 on CI (serialized) and 4 locally (parallel), exactly as
maxForksdid.Verification (vitest 4.1.9)
test-runs/kd-wgzh/logs/.createVitest()resolves the config topool:"forks", maxWorkers:1underCI=1andmaxWorkers:4unset(
test-runs/kd-wgzh/resolved-config.txt).test-runs/kd-wgzh/outcome-lists/{passed,failed,skipped}-checks.tsv(8 passed / 0 failed / 1 skipped).
cd host && npx vitest runsuite — this clean checkout hasno built wasm sysroot/kernel/release artifacts that
global-setup.tsneeds (dev-shellwasm32posix-cc+wat2wasm+ a built musl sysroot). No test case exercisespoolOptions/maxWorkersbeyond config resolution (verified above); CI runs the fullhost suite in the canonical environment. See
test-runs/kd-wgzh/DISPOSITION.md.Scope
host/vitest.config.tswas the only tracked file using the removedpoolOptions(
sdkandpackages/registry/*vitest configs never set it).Bead: kd-wgzh
🤖 Generated with Claude Code