refactor(emails): drop optimistic update from WC email toggle (NPPD-1527)

Per dkoo's review of #4727, the optimistic status update on toggleWcEmail
added specialized fetch + manual rollback logic that didn't match how
status updates work in the rest of the wizards. Fall back to the same
pattern as updateStatus in this file: fire the API call, refetch on
success, surface a notice on failure.

Author: kmwilkerson

src/wizards/newspack/views/settings/emails/emails.tsx

@@ -115,19 +115,21 @@ const Emails = () => {
 		[ postType, fetchData ]
 	);
 
-	const toggleWcEmail = useCallback( ( wcPostId: string, enabled: boolean ) => {
-		setError( null );
-		const previousStatus = enabled ? 'draft' : 'publish';
-		setData( prev => prev.map( email => ( email.post_id === wcPostId ? { ...email, status: enabled ? 'publish' : 'draft' } : email ) ) );
-		apiFetch( {
-			path: `/newspack/v1/wizard/newspack-settings/emails/${ wcPostId.replace( 'wc:', '' ) }/toggle`,
-			method: 'POST',
-			data: { enabled },
-		} ).catch( () => {
-			setData( prev => prev.map( email => ( email.post_id === wcPostId ? { ...email, status: previousStatus } : email ) ) );
-			setError( __( 'Failed to update email status.', 'newspack-plugin' ) );
-		} );
-	}, [] );
+	const toggleWcEmail = useCallback(
+		( wcPostId: string, enabled: boolean ) => {
+			setError( null );
+			apiFetch( {
+				path: `/newspack/v1/wizard/newspack-settings/emails/${ wcPostId.replace( 'wc:', '' ) }/toggle`,
+				method: 'POST',
+				data: { enabled },
+			} )
+				.then( () => fetchData() )
+				.catch( () => {
+					setError( __( 'Failed to update email status.', 'newspack-plugin' ) );
+				} );
+		},
+		[ fetchData ]
+	);
 
 	const resetEmail = useCallback(
 		( postId: number ) => {