linux

Author: chearon

build.zig

@@ -10,7 +10,7 @@ pub fn build(b: *std.Build) void {
         .use_png = true,
         .use_glib = false,
         .use_dwrite = false,
-        .use_fontconfig = false,
+        .use_fontconfig = target.result.os.tag == .linux,
         .use_freetype = true,
         .use_quartz = false,
         .target = target,
@@ -54,6 +54,7 @@ pub fn build(b: *std.Build) void {
             .target = target,
             .optimize = optimize,
             .root_source_file = b.path("src/unicode.zig"),
+            .link_libc = true,
         })
     });
 
@@ -88,7 +89,11 @@ pub fn build(b: *std.Build) void {
             "src/init.cc",
             "src/itemize.cc",
             "src/FontManager.cc",
-            "src/FontManagerMacos.cc",
+            switch (target.result.os.tag) {
+              .macos => "src/FontManagerMacos.cc",
+              .linux => "src/FontManagerLinux.cc",
+              else => @panic("unrecognized OS")
+            },
             "src/FontFace.cc",
             "src/FontFaceSet.cc",
             "src/FontParser.cc",
@@ -97,6 +102,11 @@ pub fn build(b: *std.Build) void {
         .flags = &.{
             "-DNAPI_DISABLE_CPP_EXCEPTIONS",
             "-DNODE_ADDON_API_ENABLE_MAYBE",
+            switch (target.result.os.tag) {
+              .macos => "-DCANVAS_MACOS",
+              .linux => "-DCANVAS_LINUX",
+              else => @panic("unrecognized OS")
+            },
             "-std=c++20",
             if (target.result.os.tag == .windows) "-DCAIRO_WIN32_STATIC_BUILD" else "",
         }

src/Font.h

@@ -32,7 +32,7 @@ struct FontDescriptor : FontBase {
   // Collection (ttc). macOS CTFontDescriptors don't tell you which index
   // they represent in a ttc, so when we begin to draw with a ttc match, we
   // select which index to draw with based on which one has this name.
-  std::unique_ptr<char[]> postscript;
+  std::unique_ptr<char[]> postscript = nullptr;
   std::unique_ptr<char[]> url = nullptr;
   std::unique_ptr<uint8_t[]> data = nullptr;
   size_t data_len = 0;

src/FontLayout.cc

@@ -434,7 +434,9 @@ layoutText(
         nullptr
       );
       size_t count = hb_face_count(hbblob);
-      if (count > 1) {
+      // If there's a postscript name, the backend (macOS) requires us to
+      // initialize the TTC index
+      if (count > 1 && matches[matchIndex]->postscript) {
         for (size_t index = 0; index < count; index++) {
           char buf[128];
           unsigned int len = sizeof(buf);

src/FontManager.cc

@@ -29,7 +29,6 @@ compareFamilyNames(const char* str1, size_t len1, const char* str2, size_t len2)
   return true;
 }
 
-
 void
 FontManager::narrowByStretch(
   std::vector<FontDescriptor*>& fonts,
@@ -230,7 +229,7 @@ FontManager::query(
   for (const std::string& family : properties.families) {
     auto genericFamilies = getGenericList(family);
     if (genericFamilies) {
-      for (const std::string& family : **genericFamilies) {
+      for (const std::string& family : *genericFamilies) {
         for (FontDescriptor& desc : system_fonts) {
           maybeAdd(family, &desc);
         }

src/FontManager.h

@@ -19,7 +19,7 @@ class FontManager {
       script_t script
     ) = 0;
 
-    virtual std::optional<const std::vector<std::string>*> getGenericList(
+    virtual std::optional<const std::vector<std::string>> getGenericList(
       const std::string& generic
     ) = 0;
 

src/FontManagerLinux.cc

@@ -0,0 +1,12 @@
+// Copyright (c) 2025 Caleb Hearon <caleb@chearon.net>
+
+#pragma once
+
+#include "FontManager.h"
+
+class FontManagerLinux : public FontManager {
+  public:
+    void readSystemFonts(std::vector<FontDescriptor>& properties) override;
+    void populateFallbackFonts(std::vector<std::string>& families, script_t script) override;
+    std::optional<const std::vector<std::string>> getGenericList(const std::string& generic) override;
+};

src/FontManagerLinux.h

@@ -8,7 +8,6 @@
 #include <vector>
 #include <array>
 #include <cstring>
-#include <iostream>
 #include <cmath>
 
 #include "FontManagerMacos.h"
@@ -64,7 +63,7 @@ convertWeight(float aCTWeight) {
   return round(prev->second * (1.0 - t) + m->second * t);
 }
 
-void
+static void
 create_font_descriptor(
   std::vector<FontDescriptor>& results,
   CTFontDescriptorRef descriptor
@@ -654,7 +653,7 @@ const std::vector<std::string> monospace_fonts = {"Menlo"};
 const std::vector<std::string> cursive_fonts = {"Apple Chancery"};
 const std::vector<std::string> fantasy_fonts = {"Papyrus"};
 
-std::optional<const std::vector<std::string>*>
+std::optional<const std::vector<std::string>>
 FontManagerMacos::getGenericList(const std::string& generic) {
   if (generic == "serif") {
     return &serif_fonts;

src/FontManagerMacos.cc

@@ -7,5 +7,5 @@ class FontManagerMacos : public FontManager {
   public:
     void readSystemFonts(std::vector<FontDescriptor>& properties) override;
     void populateFallbackFonts(std::vector<std::string>& families, script_t script) override;
-    std::optional<const std::vector<std::string>*> getGenericList(const std::string& generic) override;
+    std::optional<const std::vector<std::string>> getGenericList(const std::string& generic) override;
 };

src/FontManagerMacos.h

@@ -3,7 +3,12 @@
 #include <napi.h>
 #include <freetype/freetype.h>
 #include "FontFaceSet.h"
-#include "FontManagerMacos.h" // TODO per-platform
+
+#if defined(CANVAS_LINUX)
+#include "FontManagerLinux.h"
+#elif defined(CANVAS_MACOS)
+#include "FontManagerMacos.h"
+#endif
 
 struct InstanceData {
   Napi::FunctionReference CanvasCtor;
@@ -18,7 +23,11 @@ struct InstanceData {
   Napi::ObjectReference jsFontSet;
   FontFaceSet* cppFontSet;
   FT_Library ft;
+#if defined(CANVAS_LINUX)
+  FontManagerLinux fontManager;
+#elif defined(CANVAS_MACOS)
   FontManagerMacos fontManager;
+#endif
 
   InstanceData() {
     FT_Init_FreeType(&ft);