Fix invalid boolean type conversions#2563
Open
Kimapr wants to merge 1 commit intoAutomattic:masterfrom
Open
Conversation
on my computer these result in a compile error. now there is no more compile error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on my GNU Guix System computer (where i can't use the pre-built binaries because they rely on dynamic linking which needs special considerations in GNU Guix System similar to ones in NixOS) when trying to build node-canvas i get this error:
I have no idea what is
booleantype and why it exists when we've already hadboolbuilt into C++ itself since eons ago and I have even less idea why one can't be implicitly converted into the other or from anintbut it is what it is.Just adding some casts fixes the compile error. It's probably better to fix the actual
booleantype so that it allows implicit conversions but I don't even know where it is defined so i'm not doing that