Skip to content

fix: add project-level .eslintrc.js to align lint setup#340

Merged
laurelfulford merged 2 commits into
trunkfrom
fix/update-dependencies
Jun 4, 2026
Merged

fix: add project-level .eslintrc.js to align lint setup#340
laurelfulford merged 2 commits into
trunkfrom
fix/update-dependencies

Conversation

@laurelfulford

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

This PR adds a project-level .eslintrc.js, following the same format that newspack-plugin, newspack-blocks, and newspack-popups use. This repo was missing it, which meant npm run lint:js was falling back to @wordpress/scripts's default config instead of newspack-scripts.

This fixes an issue that came up in #320, where a trunk merge caused a peer-dep error in CI. Getting the repo matching other Newspack ones seemed like the safest fix.

How to test the changes in this Pull Request:

  1. Run npm ci to install deps.
  2. Run npm run build.
  3. Run npm run lint:js
  4. Confirm none of the above causes errors, and that you don't need to use --legacy-peer-deps to get the install to work.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a project-level ESLint configuration so npm run lint:js uses the newspack-scripts ESLint rules (instead of falling back to @wordpress/scripts defaults), aligning this repo’s lint setup with other Newspack projects.

Changes:

  • Add a root .eslintrc.js that extends newspack-scripts’ ESLint config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .eslintrc.js
@laurelfulford

Copy link
Copy Markdown
Contributor Author

Thanks @chickenn00dle! 🎉

@laurelfulford laurelfulford merged commit 7e7c087 into trunk Jun 4, 2026
5 checks passed
@laurelfulford laurelfulford deleted the fix/update-dependencies branch June 4, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants