Feature: Import from Google Keep#2015
Conversation
|
@mgunyho this looks great and it's so cool that you added it. we're a bit busy preparing the 1.16 release but I'd love to prioritize your PR. Please ping us again here if we haven't done more review by Monday. |
|
Hi, any update on this? |
Very nice @mgunyho you held me accountable 😄 Sadly no, we got a bit more distracted by some issues we uncovered while testing the 1.16 release. Those are mostly done. I will make sure to get you some review by the end of this weekend - setting an alert on my calendar to remind me. Thanks for your patience! We appreciate your contribution so much and are excited to move it forward! |
|
|
||
| const title = importedNote.title; | ||
| let textContent = title ? title + '\n\n' : ''; | ||
| textContent += get(importedNote, 'textContent', ''); |
There was a problem hiding this comment.
this is a minor style issue, but we don't need to mutate this variable when we can instead set it in one go
const title = importedNote.title;
const importedContent = importedNote.textContent ?? '';
const textContent = title ? `${ title }\n\n${ importedContent }` : importedContent;There was a problem hiding this comment.
I removed the mutable variable in bd9425b, do you think the code is readable?
Side note: is the ?? operator widely enough supported? With a quick glance, I couldn't find it used elsewhere in this repo.
| pinned: importedNote.isPinned, | ||
| tags: get(importedNote, 'labels', []).map(item => item.name), | ||
| }, | ||
| { ...this.options, isTrashed: importedNote.isTrashed } |
There was a problem hiding this comment.
if it were me I might suggest sending archived notes to the trash or add a tag to them - archived and leave them in the inbox.
trash is generally safe but someone could accidentally "empty the trash" and wipe out their archive
if, on the other hand, they import their archive into the "All Notes" section then they might get more notes in the list than they expect.
maybe we just need a setting…
Archived Notes: [ ] Import into trash [ ] Import with tag _________
There was a problem hiding this comment.
Yes, this is how I would do it as well. I don't know how to add a (importer-specific) setting to the dialog.
There was a problem hiding this comment.
I will try to play around with it this week and see if it wouldn't be too hard. if not, maybe adding archive to the tags could be a good interim solution?
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
This is looking great. I left some feedback on things that might be good to update. I'm sure our existing importers aren't the best examples of this, but it looks like we pass over a number of different errors/exceptions/failures in this PR and it would be nice to either handle those explicitly or add a comment in the code explaining why we're not and what we expect to happen - skip note vs. emit an error etc…
Thanks for your patience with this and thanks so much for your efforts! ❤️
| ? importedNote.listContent // Note has checkboxes, no text content | ||
| .map(item => `- [${item.isChecked ? 'x' : ' '}] ${item.text}`) | ||
| .join('\n') | ||
| : importedNote.textContent; |
There was a problem hiding this comment.
interesting. a note can only either be a list or some text?
There was a problem hiding this comment.
Yeah, in Keep, you can "show checkboxes", which turns the whole note into a checklist, and as far as I can tell there's no way to have regular text then.
|
Any updates? |
|
@KnifeFed if there were updates you'd see them here, so no, unfortunately there are none. |
3 participants
Fix
This PR adds the option to import notes from Google Keep. Notes can be either imported from a zip file exported from Google Takeout, or as individual JSON files. Attached is a small test file that contains notes with various features (check boxes, tags, etc.).
A couple of things to note:
annotationsattribute that could be used for this.I'm fairly new to typescript, so let me know if something looks wrong in the code!
Test
Release
RELEASE-NOTES.txtwas updated with: