Revert "Fix flaky WordPress server startup test"

This reverts commit cec9ac3.

Author: shaunandrews

apps/cli/lib/tests/wordpress-server-manager.test.ts

@@ -97,29 +97,6 @@ describe( 'WordPress Server Manager', () => {
 		} );
 	}
 
-	function mockStartProcessExit( {
-		beforeExit,
-		stderrTail,
-	}: {
-		beforeExit?: () => void;
-		stderrTail?: string;
-	} = {} ): void {
-		vi.mocked( daemonClient.startProcess ).mockImplementation( async () => {
-			setImmediate( () => {
-				beforeExit?.();
-				mockBus.emit( 'process-event', {
-					process: {
-						name: mockProcessDescription.name,
-						pm_id: mockProcessDescription.pmId,
-					},
-					event: 'exit',
-					...( stderrTail ? { stderrTail } : {} ),
-				} );
-			} );
-			return mockProcessDescription;
-		} );
-	}
-
 	describe( 'isServerRunning', () => {
 		it( 'should check if process is running with correct process name', async () => {
 			const mockProcess = {
@@ -287,7 +264,15 @@ describe( 'WordPress Server Manager', () => {
 
 		it( 'should surface an error when the child process exits before becoming ready', async () => {
 			// Do not emit `ready`; instead emit an `exit` event to simulate a crash during startup.
-			mockStartProcessExit();
+			setTimeout( () => {
+				mockBus.emit( 'process-event', {
+					process: {
+						name: mockProcessDescription.name,
+						pm_id: mockProcessDescription.pmId,
+					},
+					event: 'exit',
+				} );
+			}, 10 );
 
 			await expect( startWordPressServer( mockSiteData, mockLogger ) ).rejects.toThrow(
 				/exited before becoming ready/
@@ -296,7 +281,17 @@ describe( 'WordPress Server Manager', () => {
 
 		it( 'should include the child stderr tail in the error when the daemon provides it', async () => {
 			const stderrTail = 'SyntaxError: The requested module did not provide an export named X';
-			mockStartProcessExit( { stderrTail } );
+
+			setTimeout( () => {
+				mockBus.emit( 'process-event', {
+					process: {
+						name: mockProcessDescription.name,
+						pm_id: mockProcessDescription.pmId,
+					},
+					event: 'exit',
+					stderrTail,
+				} );
+			}, 10 );
 
 			await expect( startWordPressServer( mockSiteData, mockLogger ) ).rejects.toThrow(
 				new RegExp( stderrTail.replace( /[.*+?^${}()|[\]\\]/g, '\\$&' ) )
@@ -332,11 +327,16 @@ describe( 'WordPress Server Manager', () => {
 			await fs.promises.mkdir( path.join( sitePath, 'wp-content' ), { recursive: true } );
 			const logPath = path.join( sitePath, 'wp-content', STUDIO_ERROR_LOG_FILENAME );
 
-			mockStartProcessExit( {
-				beforeExit: () => {
-					fs.writeFileSync( logPath, 'PHP Fatal error: Uncaught Error: Failed opening required' );
-				},
-			} );
+			setTimeout( () => {
+				fs.writeFileSync( logPath, 'PHP Fatal error: Uncaught Error: Failed opening required' );
+				mockBus.emit( 'process-event', {
+					process: {
+						name: mockProcessDescription.name,
+						pm_id: mockProcessDescription.pmId,
+					},
+					event: 'exit',
+				} );
+			}, 10 );
 
 			await expect(
 				startWordPressServer( { ...mockSiteData, path: sitePath }, mockLogger )
@@ -350,7 +350,15 @@ describe( 'WordPress Server Manager', () => {
 			const logPath = path.join( sitePath, 'wp-content', 'debug.log' );
 			fs.writeFileSync( logPath, 'PHP Fatal error: from a previous run' );
 
-			mockStartProcessExit();
+			setTimeout( () => {
+				mockBus.emit( 'process-event', {
+					process: {
+						name: mockProcessDescription.name,
+						pm_id: mockProcessDescription.pmId,
+					},
+					event: 'exit',
+				} );
+			}, 10 );
 
 			const error: Error = await startWordPressServer(
 				{ ...mockSiteData, path: sitePath, enableDebugLog: true },
@@ -370,11 +378,16 @@ describe( 'WordPress Server Manager', () => {
 			await fs.promises.mkdir( path.join( sitePath, 'wp-content' ), { recursive: true } );
 			const logPath = path.join( sitePath, 'wp-content', 'debug.log' );
 
-			mockStartProcessExit( {
-				beforeExit: () => {
-					fs.writeFileSync( logPath, 'PHP Fatal error: Uncaught Error: Failed opening required' );
-				},
-			} );
+			setTimeout( () => {
+				fs.writeFileSync( logPath, 'PHP Fatal error: Uncaught Error: Failed opening required' );
+				mockBus.emit( 'process-event', {
+					process: {
+						name: mockProcessDescription.name,
+						pm_id: mockProcessDescription.pmId,
+					},
+					event: 'exit',
+				} );
+			}, 10 );
 
 			await expect(
 				startWordPressServer(