Lint scripts from the root config (#3310)

Co-authored-by: Codex GPT-5 <noreply@openai.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Author: 3 people

eslint.config.mjs

@@ -125,6 +125,12 @@ export default defineConfig(
 			'@typescript-eslint/no-require-imports': 'off',
 		},
 	},
+	{
+		files: [ 'scripts/**/*.js', 'scripts/**/*.cjs' ],
+		rules: {
+			'@typescript-eslint/no-require-imports': 'off',
+		},
+	},
 	{
 		files: [ 'apps/cli/**/*.{ts,tsx}' ],
 		ignores: [ 'apps/cli/vite.config*.ts', 'apps/cli/vitest.config.ts' ],
@@ -141,5 +147,21 @@ export default defineConfig(
 				},
 			],
 		},
+	},
+	{
+		files: [ 'scripts/**/*.mjs' ],
+		rules: {
+			'no-restricted-globals': [
+				'error',
+				{
+					name: '__dirname',
+					message: 'Use import.meta.dirname in ESM modules.',
+				},
+				{
+					name: '__filename',
+					message: 'Use import.meta.filename in ESM modules.',
+				},
+			],
+		},
 	}
 );

package.json

@@ -47,7 +47,7 @@
 		"cli:watch": "npm -w wp-studio run watch",
 		"app:install:bundle": "npm -w studio-app run install:bundle",
 		"compare:perf": "npm -w compare-perf run compare",
-		"lint": "eslint {apps/cli,apps/studio/src,apps/studio/e2e,apps/ui/src,tools/common}",
+		"lint": "eslint {apps/cli,apps/studio/src,apps/studio/e2e,apps/ui/src,tools/common,scripts}",
 		"typecheck": "npm run typecheck --workspaces --if-present && tsc -p scripts/tsconfig.json --noEmit",
 		"format": "npm run lint -- --fix",
 		"test": "vitest run",

scripts/azure-sign-hook.js

@@ -3,8 +3,6 @@
 // (sha1 + sha256) fails because there's no local cert for sha1.
 // This hook calls signtool directly with SHA256-only parameters.
 
-/* eslint-disable @typescript-eslint/no-require-imports */
-
 const { execFileSync } = require( 'child_process' );
 const path = require( 'path' );
 const {

scripts/download-available-site-translations.mjs

@@ -1,16 +1,13 @@
 import fs from 'fs';
 import https from 'https';
 import path from 'path';
-import { fileURLToPath } from 'url';
-
-const __dirname = path.dirname( fileURLToPath( import.meta.url ) );
 
 console.log(
 	'[available-site-translations] Downloading information of available translations for latest WordPress version ...'
 );
 
 const jsonFilePath = path.join(
-	__dirname,
+	import.meta.dirname,
 	'..',
 	'wp-files',
 	'latest',

scripts/download-node-binary.ts

@@ -6,8 +6,8 @@
  */
 
 import fs from 'fs';
-import path from 'path';
 import os from 'os';
+import path from 'path';
 import { extract } from 'tar';
 import { extractZip } from '../tools/common/lib/extract-zip';
 
@@ -172,4 +172,4 @@ async function main(): Promise< void > {
 	}
 }
 
-main();
+void main();

scripts/make-dmg.mjs

@@ -1,10 +1,8 @@
 import child_process from 'child_process';
 import * as fs from 'fs';
 import * as path from 'path';
-import { fileURLToPath } from 'url';
 import packageJson from '../apps/studio/package.json' with { type: 'json' };
 
-const __dirname = path.dirname( fileURLToPath( import.meta.url ) );
 const fileArchitecture = process.env.FILE_ARCHITECTURE;
 
 if ( ! fileArchitecture ) {
@@ -13,7 +11,7 @@ if ( ! fileArchitecture ) {
 	);
 }
 
-const outDir = path.resolve( __dirname, '../apps/studio/out' );
+const outDir = path.resolve( import.meta.dirname, '../apps/studio/out' );
 
 const appPath = path.resolve(
 	outDir,
@@ -26,8 +24,14 @@ const dmgPath = path.resolve(
 	`${ packageJson.productName }-darwin-${ fileArchitecture }.dmg`
 );
 
-const volumeIconPath = path.resolve( __dirname, '../apps/studio/assets/studio-app-icon.icns' );
-const backgroundPath = path.resolve( __dirname, '../apps/studio/assets/dmg-background.png' );
+const volumeIconPath = path.resolve(
+	import.meta.dirname,
+	'../apps/studio/assets/studio-app-icon.icns'
+);
+const backgroundPath = path.resolve(
+	import.meta.dirname,
+	'../apps/studio/assets/dmg-background.png'
+);
 
 const dmgSpecs = {
 	title: packageJson.productName,
@@ -50,9 +54,13 @@ if ( fs.existsSync( dmgPath ) ) {
 }
 fs.mkdirSync( path.dirname( dmgPath ), { recursive: true } );
 
-const specsFile = path.resolve( __dirname, '..', 'appdmg-specs.json' );
+const specsFile = path.resolve( import.meta.dirname, '..', 'appdmg-specs.json' );
 fs.writeFileSync( specsFile, JSON.stringify( dmgSpecs ) );
-child_process.execSync(
-	[ path.join( __dirname, '..', 'node_modules', '.bin', `appdmg` ), specsFile, dmgPath ].join( ' ' )
-);
-fs.unlinkSync( specsFile );
+const appdmgBin = path.join( import.meta.dirname, '..', 'node_modules', '.bin', 'appdmg' );
+try {
+	child_process.execFileSync( appdmgBin, [ specsFile, dmgPath ] );
+} finally {
+	if ( fs.existsSync( specsFile ) ) {
+		fs.unlinkSync( specsFile );
+	}
+}

scripts/package-appx.mjs

@@ -1,7 +1,6 @@
 import { execFileSync } from 'child_process';
 import fs from 'fs/promises';
 import path from 'path';
-import { fileURLToPath } from 'url';
 import convertToWindowsStore from 'electron2appx';
 import packageJson from '../apps/studio/package.json' with { type: 'json' };
 
@@ -29,16 +28,18 @@ if ( useAzureSigning ) {
 	}
 }
 
-const __dirname = path.dirname( fileURLToPath( import.meta.url ) );
-
 // Get architecture from environment variable, default to x64 for backward compatibility
 const architecture = process.env.FILE_ARCHITECTURE || 'x64';
 if ( architecture !== 'x64' && architecture !== 'arm64' ) {
 	console.error( `Invalid architecture: ${ architecture }. Must be 'x64' or 'arm64'.` );
 	process.exit( 1 );
 }
 
-const windows10SDKVersionPath = path.resolve( __dirname, '..', '.windows-10-sdk-version' );
+const windows10SDKVersionPath = path.resolve(
+	import.meta.dirname,
+	'..',
+	'.windows-10-sdk-version'
+);
 try {
 	await fs.access( windows10SDKVersionPath );
 } catch {
@@ -62,8 +63,8 @@ try {
 	process.exit( 1 );
 }
 
-const outPath = path.join( __dirname, '..', 'apps', 'studio', 'out' );
-const assetsPath = path.join( __dirname, '..', 'apps', 'studio', 'assets', 'appx' );
+const outPath = path.join( import.meta.dirname, '..', 'apps', 'studio', 'out' );
+const assetsPath = path.join( import.meta.dirname, '..', 'apps', 'studio', 'assets', 'appx' );
 
 console.log( `~~~ Packaging AppX for architecture: ${ architecture }` );
 

scripts/package-in-isolation.ts

@@ -90,7 +90,7 @@ function main() {
 	const studioAppScripts = getStudioAppScripts();
 	const scriptName = process.argv[ 2 ];
 
-	if ( ! studioAppScripts.hasOwnProperty( scriptName ) ) {
+	if ( ! Object.prototype.hasOwnProperty.call( studioAppScripts, scriptName ) ) {
 		throw new Error(
 			`Unsupported script "${ scriptName }". Supported studio-app packaging scripts: ${ Object.keys(
 				studioAppScripts

scripts/prepare-dev-build-version.mjs

@@ -3,8 +3,8 @@
 import fs from 'fs/promises';
 import path from 'path';
 import semver from 'semver';
-import { getLatestTag, getCommitCount } from './lib/git-utils.mjs';
 import packageJson from '../apps/studio/package.json' with { type: 'json' };
+import { getCommitCount, getLatestTag } from './lib/git-utils.mjs';
 
 const latestTag = getLatestTag();
 const commitCount = getCommitCount( latestTag );

scripts/start-new-ui.mjs

@@ -9,11 +9,9 @@
  */
 
 import { spawn } from 'child_process';
-import { dirname, resolve } from 'path';
-import { fileURLToPath } from 'url';
+import { resolve } from 'path';
 
-const scriptDir = dirname( fileURLToPath( import.meta.url ) );
-const root = resolve( scriptDir, '..' );
+const root = resolve( import.meta.dirname, '..' );
 
 const UI_DEV_PORT = 5200;