Upgrade archiver to v7 to fix glob and inflight deprecation warnings (#3050)

wojtekn · Kateryna Kodonenko · commit 9c2052dfd7bb · 2026-04-10T15:42:17.000+02:00
* CLI: upgrade archiver to v7 to fix glob and inflight deprecation warnings archiver@6 → archiver@7 pulls in archiver-utils@5 which uses glob@10 instead of glob@8, eliminating the glob and inflight deprecation warnings. @types/archiver@7 dropped followSymlinks from CoreOptions (it's still supported at runtime), so cast ArchiverOptions at call sites instead of patching node_modules. Also fixes the broken ProgressData named import which doesn't work with the export= module style in @types/archiver@7. * Studio: upgrade archiver to v7, drop @types/archiver patch Consistent with the CLI upgrade. Drops the @types+archiver+6.0.4 patch in favour of the same cast-based approach used in apps/cli. * Studio: remove obsolete archiver@6 runtime patch
diff --git a/apps/cli/lib/archive.ts b/apps/cli/lib/archive.ts
@@ -18,7 +18,7 @@ export async function archiveSiteContent(
 		const archiveBuilder = archiver( 'zip', {
 			zlib: { level: ZIP_COMPRESSION_LEVEL },
 			followSymlinks: true,
-		} );
+		} as archiver.ArchiverOptions );
 
 		output.on( 'close', () => {
 			resolve( archiveBuilder );
diff --git a/apps/cli/lib/import-export/export/exporters/default-exporter.ts b/apps/cli/lib/import-export/export/exporters/default-exporter.ts
@@ -153,7 +153,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {
 		this.emit( ExportEvents.BACKUP_CREATE_START );
 		const isZip = this.options.backupFile.endsWith( '.zip' );
 		const format = isZip ? 'zip' : 'tar';
-		return archiver( format, ARCHIVER_OPTIONS[ format ] );
+		return archiver( format, ARCHIVER_OPTIONS[ format ] as archiver.ArchiverOptions );
 	}
 
 	private setupArchiveListeners( output: fs.WriteStream ): Promise< void > {
diff --git a/apps/cli/lib/import-export/export/types.ts b/apps/cli/lib/import-export/export/types.ts
@@ -1,5 +1,5 @@
 import { SiteData } from 'cli/lib/cli-config/core';
-import type { ProgressData } from 'archiver';
+import type archiver from 'archiver';
 import type { EventEmitter } from 'events';
 
 export interface ExportOptions {
@@ -24,7 +24,7 @@ export interface Exporter extends Partial< EventEmitter > {
 }
 
 export interface BackupCreateProgressEventData {
-	progress: ProgressData;
+	progress: archiver.ProgressData;
 }
 
 export type NewExporter = new ( options: ExportOptions ) => Exporter;
diff --git a/apps/cli/lib/tests/archive.test.ts b/apps/cli/lib/tests/archive.test.ts
@@ -51,8 +51,8 @@ describe( 'Archive Module', () => {
 		vi.clearAllMocks();
 		mockArchiver = createMockArchiver();
 		mockWriteStream = createMockWriteStream();
-		vi.mocked( archiver ).mockReturnValue(
-			mockArchiver as unknown as ReturnType< typeof archiver >
+		vi.mocked( archiver as unknown as ( ...args: unknown[] ) => unknown ).mockReturnValue(
+			mockArchiver
 		);
 		vi.mocked( fs.createWriteStream ).mockReturnValue(
 			mockWriteStream as unknown as ReturnType< typeof fs.createWriteStream >
diff --git a/apps/cli/package.json b/apps/cli/package.json
@@ -37,7 +37,7 @@
 		"@wp-playground/common": "3.1.18",
 		"@wp-playground/storage": "3.1.18",
 		"@wp-playground/wordpress": "3.1.18",
-		"archiver": "^6.0.2",
+		"archiver": "^7.0.1",
 		"atomically": "^2.1.1",
 		"chalk": "^5.6.2",
 		"cli-table3": "^0.6.5",
@@ -68,7 +68,7 @@
 	},
 	"devDependencies": {
 		"@studio/common": "file:../../tools/common",
-		"@types/archiver": "^6.0.4",
+		"@types/archiver": "^7.0.0",
 		"@types/http-proxy": "^1.17.17",
 		"@types/node-forge": "^1.3.14",
 		"@types/yargs": "^17.0.35",
diff --git a/apps/studio/package.json b/apps/studio/package.json
@@ -43,7 +43,7 @@
 		"@wordpress/i18n": "^6.9.0",
 		"@wordpress/icons": "^11.4.0",
 		"@wordpress/react-i18n": "^4.41.0",
-		"archiver": "^6.0.2",
+		"archiver": "^7.0.1",
 		"atomically": "^2.1.0",
 		"cli-table3": "^0.6.5",
 		"compressible": "2.0.18",
@@ -86,7 +86,7 @@
 		"@electron-forge/maker-zip": "^7.11.1",
 		"@electron-forge/plugin-auto-unpack-natives": "^7.11.1",
 		"@sentry/vite-plugin": "^5.1.1",
-		"@types/archiver": "^6.0.4",
+		"@types/archiver": "^7.0.0",
 		"@types/follow-redirects": "^1.14.4",
 		"@types/fs-extra": "^11.0.4",
 		"@types/http-proxy": "^1.17.17",
diff --git a/apps/studio/patches/@types+archiver+6.0.4.patch b/apps/studio/patches/@types+archiver+6.0.4.patch
diff --git a/apps/studio/patches/archiver+6.0.2.patch b/apps/studio/patches/archiver+6.0.2.patch
diff --git a/apps/studio/src/lib/import-export/export/exporters/default-exporter.ts b/apps/studio/src/lib/import-export/export/exporters/default-exporter.ts
@@ -154,7 +154,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {
 		this.emit( ExportEvents.BACKUP_CREATE_START );
 		const isZip = this.options.backupFile.endsWith( '.zip' );
 		const format = isZip ? 'zip' : 'tar';
-		return archiver( format, ARCHIVER_OPTIONS[ format ] );
+		return archiver( format, ARCHIVER_OPTIONS[ format ] as archiver.ArchiverOptions );
 	}
 
 	private setupArchiveListeners( output: fs.WriteStream ): Promise< void > {
diff --git a/apps/studio/src/lib/import-export/export/types.ts b/apps/studio/src/lib/import-export/export/types.ts
@@ -1,4 +1,4 @@
-import type { ProgressData } from 'archiver';
+import type archiver from 'archiver';
 import type { EventEmitter } from 'events';
 
 export interface ExportOptions {
@@ -23,7 +23,7 @@ export interface Exporter extends Partial< EventEmitter > {
 }
 
 export interface BackupCreateProgressEventData {
-	progress: ProgressData;
+	progress: archiver.ProgressData;
 }
 
 export type NewExporter = new ( options: ExportOptions ) => Exporter;
diff --git a/apps/studio/src/lib/import-export/tests/export/exporters/default-exporter.test.ts b/apps/studio/src/lib/import-export/tests/export/exporters/default-exporter.test.ts
@@ -270,8 +270,8 @@ platformTestSuite( 'DefaultExporter', ( { normalize } ) => {
 		} );
 
 		mockArchiver = createMockArchiver();
-		( archiver as MockedFunction< typeof archiver > ).mockReturnValue(
-			mockArchiver as unknown as archiver.Archiver
+		( archiver as unknown as MockedFunction< ( ...args: unknown[] ) => unknown > ).mockReturnValue(
+			mockArchiver
 		);
 		mockWriteStream = {
 			on: vi.fn(),
diff --git a/package-lock.json b/package-lock.json

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {`
`153`	`153`	`this.emit( ExportEvents.BACKUP_CREATE_START );`
`154`	`154`	`const isZip = this.options.backupFile.endsWith( '.zip' );`
`155`	`155`	`const format = isZip ? 'zip' : 'tar';`
`156`		`- return archiver( format, ARCHIVER_OPTIONS[ format ] );`
	`156`	`+ return archiver( format, ARCHIVER_OPTIONS[ format ] as archiver.ArchiverOptions );`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`private setupArchiveListeners( output: fs.WriteStream ): Promise< void > {`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import { SiteData } from 'cli/lib/cli-config/core';`
`2`		`-import type { ProgressData } from 'archiver';`
	`2`	`+import type archiver from 'archiver';`
`3`	`3`	`import type { EventEmitter } from 'events';`
`4`	`4`
`5`	`5`	`export interface ExportOptions {`
`@@ -24,7 +24,7 @@ export interface Exporter extends Partial< EventEmitter > {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`export interface BackupCreateProgressEventData {`
`27`		`- progress: ProgressData;`
	`27`	`+ progress: archiver.ProgressData;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`export type NewExporter = new ( options: ExportOptions ) => Exporter;`
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {`
`154`	`154`	`this.emit( ExportEvents.BACKUP_CREATE_START );`
`155`	`155`	`const isZip = this.options.backupFile.endsWith( '.zip' );`
`156`	`156`	`const format = isZip ? 'zip' : 'tar';`
`157`		`- return archiver( format, ARCHIVER_OPTIONS[ format ] );`
	`157`	`+ return archiver( format, ARCHIVER_OPTIONS[ format ] as archiver.ArchiverOptions );`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`private setupArchiveListeners( output: fs.WriteStream ): Promise< void > {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { ProgressData } from 'archiver';`
	`1`	`+import type archiver from 'archiver';`
`2`	`2`	`import type { EventEmitter } from 'events';`
`3`	`3`
`4`	`4`	`export interface ExportOptions {`
`@@ -23,7 +23,7 @@ export interface Exporter extends Partial< EventEmitter > {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`export interface BackupCreateProgressEventData {`
`26`		`- progress: ProgressData;`
	`26`	`+ progress: archiver.ProgressData;`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`export type NewExporter = new ( options: ExportOptions ) => Exporter;`