Skip to content

Delete site confirmation layout is broken in agentic UI#4157

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/layout-of-delete-confirmation
Jul 10, 2026
Merged

Delete site confirmation layout is broken in agentic UI#4157
katinthehatsite merged 1 commit into
trunkfrom
fix/layout-of-delete-confirmation

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1921

How AI was used in this PR

Not needed

Proposed Changes

This PR ensures that the layout of the delete confirmation dialog for a site has appropriate paddings and margins.

Before

Screenshot 2026-07-10 at 9 55 34 AM

After

Screenshot 2026-07-10 at 9 59 05 AM

Testing Instructions

  • Pull the changes from this branch
  • Start Studio with npm start
  • Enable the Agentic UI feature flag from Studio -> Feature flags from the topbar
  • Click on the ellipsis menu by a site
  • Select an option to delete a site
  • Confirm that the dialog to delete a site has correct margins and paddings

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Jul 10, 2026
@katinthehatsite
katinthehatsite requested a review from a team July 10, 2026 08:02

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

CleanShot 2026-07-10 at 13 37 16@2x

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 6278095 vs trunk

app-size

Metric trunk 6278095 Diff Change
App Size (Mac) 1419.29 MB 1419.29 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 6278095 Diff Change
load 1090 ms 742 ms 348 ms 🟢 -31.9%

site-startup

Metric trunk 6278095 Diff Change
siteCreation 6528 ms 6986 ms +458 ms 🔴 7.0%
siteStartup 2393 ms 2403 ms +10 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@katinthehatsite
katinthehatsite merged commit 7a65431 into trunk Jul 10, 2026
12 checks passed
@katinthehatsite
katinthehatsite deleted the fix/layout-of-delete-confirmation branch July 10, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants