Studio: SiteForm path does not accommodate long site names#2333
Merged
Conversation
Contributor
📊 Performance Test ResultsComparing 9413d87 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Contributor
|
During testing, I noticed unusual behavior where the renderer crashes when the site name is excessively long. I believe this is a separate issue, so I reported it in Linear under STU-1182. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
Fixes STU-1181
Proposed Changes
This PR ensures that when you have a long path name while creating a site, it does not get cut off:
Before
Testing Instructions
npm startAdd siteoption in the sidebarAdvanced settingsPre-merge Checklist