Skip to content

Move backup fixtures to a shared root-level test-fixtures/ directory#4151

Merged
gcsecsey merged 3 commits into
trunkfrom
gcsecsey/stu-1866-move-backup-fixtures
Jul 10, 2026
Merged

Move backup fixtures to a shared root-level test-fixtures/ directory#4151
gcsecsey merged 3 commits into
trunkfrom
gcsecsey/stu-1866-move-backup-fixtures

Conversation

@gcsecsey

@gcsecsey gcsecsey commented Jul 9, 2026

Copy link
Copy Markdown
Member

Related issues

How AI was used in this PR

Claude Code planned and implemented the change under my direction, and I reviewed the result.

Proposed Changes

The minimal backup fixtures added in #4057 are currently under apps/studio/e2e/fixtures/, which ties them to the Playwright desktop suite. The upcoming CLI-based import tests (STU-1870) need the same archives, and reaching into apps/studio/e2e/** from apps/cli tests would couple them to a directory the project is migrating away from.

This PR:

  • Moves apps/studio/e2e/fixtures/backups/ to a root-level test-fixtures/backups/
  • mirrors how playwright.config.ts and vitest.config.ts already sit at the root
  • No behavior change

Testing Instructions

  1. Confirm the E2E Tests CI jobs are green (import-formats.test.ts runs there and covers all four backup formats)
  2. Optionally verify no stale references remain: git grep -n "fixtures/backups" should only match test-fixtures/backups paths.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gcsecsey gcsecsey requested review from a team and gavande1 July 9, 2026 14:05
@gcsecsey gcsecsey marked this pull request as ready for review July 9, 2026 14:05
@wpmobilebot

wpmobilebot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 514e1f5 vs trunk

app-size

Metric trunk 514e1f5 Diff Change
App Size (Mac) 1419.29 MB 1419.29 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 514e1f5 Diff Change
load 1070 ms 1087 ms +17 ms ⚪ 0.0%

site-startup

Metric trunk 514e1f5 Diff Change
siteCreation 6996 ms 6996 ms 0 ms ⚪ 0.0%
siteStartup 2362 ms 2351 ms 11 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving fixtures makes sense. LGTM 👍

@gcsecsey gcsecsey merged commit fb38954 into trunk Jul 10, 2026
12 checks passed
@gcsecsey gcsecsey deleted the gcsecsey/stu-1866-move-backup-fixtures branch July 10, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants