Move backup fixtures to a shared root-level test-fixtures/ directory#4151
Merged
Conversation
1 task
Collaborator
📊 Performance Test ResultsComparing 514e1f5 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
…ve-backup-fixtures
gavande1
approved these changes
Jul 10, 2026
gavande1
left a comment
Contributor
There was a problem hiding this comment.
Moving fixtures makes sense. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code planned and implemented the change under my direction, and I reviewed the result.
Proposed Changes
The minimal backup fixtures added in #4057 are currently under
apps/studio/e2e/fixtures/, which ties them to the Playwright desktop suite. The upcoming CLI-based import tests (STU-1870) need the same archives, and reaching intoapps/studio/e2e/**fromapps/clitests would couple them to a directory the project is migrating away from.This PR:
apps/studio/e2e/fixtures/backups/to a root-leveltest-fixtures/backups/playwright.config.tsandvitest.config.tsalready sit at the rootTesting Instructions
E2E TestsCI jobs are green (import-formats.test.tsruns there and covers all four backup formats)git grep -n "fixtures/backups"should only matchtest-fixtures/backupspaths.Pre-merge Checklist