Federate the Podlove episode summary#3457
Open
pfefferle wants to merge 10 commits into
Open
Conversation
Podlove stores an episode's summary separately from post_content, so it was never federated. Override the transformer's get_summary() to prefer the episode summary (falling back to the default summary, and leaving Notes without one). Adds a Podlove Episode test stub and regression tests for the summary and the fallback. Fixes #3455.
github-actions
Bot
added
[Focus] Compatibility
There was a problem hiding this comment.
Pull request overview
This pull request updates the Podlove Podcast Publisher integration so that Podlove’s per-episode summary (stored outside post_content) is federated via the ActivityPub object summary, with regression tests and a minimal Podlove Episode test stub.
Changes:
- Override the Podlove transformer’s
get_summary()to prefer\Podlove\Model\Episode::$summary(with fallback to the default post summary). - Add PHPUnit integration tests covering the Podlove summary behavior and fallback behavior.
- Add a minimal Podlove
Episodemodel stub for tests and a changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
integration/class-podlove-podcast-publisher.php |
Adds a get_summary() override to federate the Podlove episode summary. |
tests/phpunit/tests/integration/class-test-podlove-podcast-publisher.php |
Adds setup/teardown to load/reset a Podlove Episode stub and adds summary regression tests. |
tests/phpunit/includes/class-episode.php |
Introduces a minimal \Podlove\Model\Episode stub used by tests. |
.github/changelog/add-podlove-episode-summary |
Documents the new Podlove episode summary federation behavior. |
Strip shortcodes, tags, and decode entities (as generate_post_summary does) before federating, and fall back to the default summary when the sanitized result is empty. Tests now cover entity/tag sanitization and a markup-only summary falling back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podlove stores an episode's summary separately from post_content, so it was
never federated. Override the transformer's get_summary() to prefer the episode
summary (falling back to the default summary, and leaving Notes without one).
Adds a Podlove Episode test stub and regression tests for the summary and the
fallback.
Fixes #3455.