-
Notifications
You must be signed in to change notification settings - Fork 89
Federate the Podlove episode summary #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pfefferle
wants to merge
10
commits into
trunk
Choose a base branch
from
add/podlove-episode-summary
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+192
−0
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7305107
Federate the Podlove episode summary
pfefferle a061c8a
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle 1210ed7
Sanitize the Podlove episode summary like the default summary
pfefferle 89eacce
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle 5b753fe
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle 9ac1d25
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle ba3b3f0
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle 56882be
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle 0598248
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle b96a1b7
Merge branch 'trunk' into add/podlove-episode-summary
pfefferle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Federate the episode summary for Podlove Podcast Publisher episodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| <?php | ||
| /** | ||
| * Minimal Podlove Episode model stub for tests. | ||
| * | ||
| * @package Activitypub | ||
| */ | ||
|
|
||
| namespace Podlove\Model; | ||
|
|
||
| if ( ! class_exists( __NAMESPACE__ . '\Episode' ) ) { | ||
| /** | ||
| * Stub of the Podlove Episode model exposing only what the integration reads. | ||
| * | ||
| * `find_one_by_post_id()` returns whatever the test assigns to `$mock` (null by | ||
| * default, so the absent-Podlove fallbacks keep working). The audio/duration/ | ||
| * cover/title accessors return empty values so `to_object()` can build a full | ||
| * object without fatals while a test exercises the summary path. Parameters the | ||
| * real API takes are omitted; PHP ignores the extra call arguments. | ||
| */ | ||
| class Episode { | ||
| /** | ||
| * The episode returned by find_one_by_post_id(), or null. | ||
| * | ||
| * @var self|null | ||
| */ | ||
| public static $mock = null; | ||
|
|
||
| /** | ||
| * The episode summary. | ||
| * | ||
| * @var string | ||
| */ | ||
| public $summary = ''; | ||
|
|
||
| /** | ||
| * Resolve the episode for a post id. | ||
| * | ||
| * @return self|null The mocked episode or null. | ||
| */ | ||
| public static function find_one_by_post_id() { | ||
| return self::$mock; | ||
| } | ||
|
pfefferle marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Media files for the episode. | ||
| * | ||
| * @return array Always empty in the stub. | ||
| */ | ||
| public function media_files() { | ||
| return array(); | ||
| } | ||
|
|
||
| /** | ||
| * Episode duration. | ||
| * | ||
| * @return null Always null in the stub. | ||
| */ | ||
| public function get_duration() { | ||
| return null; | ||
| } | ||
|
pfefferle marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Episode cover art. | ||
| * | ||
| * @return null Always null in the stub. | ||
| */ | ||
| public function cover_art_with_fallback() { | ||
| return null; | ||
| } | ||
|
|
||
| /** | ||
| * Episode title. | ||
| * | ||
| * @return string Always empty in the stub. | ||
| */ | ||
| public function title() { | ||
| return ''; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.