Dashboard: warn when Profile email uses a custom domain#112201
Conversation
Ports the custom-domain account-recovery warning from Calypso's account settings to the new Dashboard Profile page. Ref: DOTMSD-1310
Render the warning as help text under the email input (matching Calypso's altitude) instead of a Notice banner. Ref: DOTMSD-1310
Drop the custom has-warning styling; show the warning through the InputControl help prop with default styling. No bespoke CSS. Ref: DOTMSD-1310
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
…tion test Per client/dashboard/docs/testing.md, simple utilities are covered via integration tests. Move the subdomain edge case into index.test.tsx. Ref: DOTMSD-1310
fushar
left a comment
There was a problem hiding this comment.
Tested. Works. Left a very small comment.
BTW it seems the before-after images in the PR description are the same.
Co-authored-by: Ashar Fuadi <ashar.fuadi@automattic.com>
They are not. See label case :). That's how great this PR is. |
|
Looks like one of the E2E tests has failed. You can fix them following these steps:
|
fushar
left a comment
There was a problem hiding this comment.
They are not. See label case :). That's how great this PR is.
Ohhhh I see, I thought Current means the MSD profile page before this PR 👍
No, :). Current means calypso's account page. Confusion noted. Will be more accurate with copy moving forward. |
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/34220110 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @StevenDufresne for including a screenshot in the description! This is really helpful for our translators. |
|
Translation for this Pull Request has now been finished. |
Fixes DOTMSD-1310
Proposed Changes
Why are these changes being made?
Considerations
Use a banner
This looks better, but demands visual attention.
Testing Instructions
/me/accounton the Dashboard.test@somedomain.com), confirm the warning appears under the Email address field.test@gmail.com), confirm no warning shows.Considerations
Pre-merge Checklist
🤖 Generated with Claude Code