React 19: upgrade standalone Calypso build - final bump - attempt 2#112339
Conversation
matticbot
added
the
[Status] Needs Review
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| "strict": true, | ||
| "checkJs": false, | ||
| "isolatedModules": true, | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
[follow-up] Issue: Adding skipLibCheck: true to the shared JS-package TypeScript config disables type-checking of all .d.ts files across every package that extends this base config. This weakens the type safety guarantees repo-wide and can mask real issues in declaration files — both from dependencies and from the project's own types.
Suggestion: This is understandable during the React 19 migration period (React 18 and 19 @types/react coexistence causes declaration conflicts), but it should be tracked as a follow-up to remove once all packages have fully migrated. Consider adding a comment here noting the intent to revert this once the migration is complete.
Source: client/AGENTS.md
Use strict TypeScript. No
anyunless justified.
1071e2b to
ee88226
Compare
|
Looks like one of the E2E tests has failed. You can fix them following these steps:
|
ee88226 to
803550d
Compare
github-actions
Bot
removed
the
[Status] Needs Review
2 participants
Brings back #112095 with Agencies fixes detected here: p1783358886041719/1783358435.166639-slack-C02DQP0FP