Fix PHPUnit cache writes through readonly mounts

Author: chubes4

packages/runtime-playground/src/phpunit-command-handlers.ts

@@ -274,7 +274,9 @@ function ${options.relativeFunctionName}(string $path, string $${options.rootPar
 
 function phpunitArgsPhp(functionName: string, logFunction: string): string {
   return `function ${functionName}(array $argv) {
-    $arguments = array('colors' => 'never', 'testdox' => true, 'verbose' => false, 'extensions' => array());
+    // PHPUnit otherwise writes .phpunit.result.cache relative to the mounted
+    // plugin working directory. Readonly mounts must not acquire that side effect.
+    $arguments = array('colors' => 'never', 'testdox' => true, 'verbose' => false, 'extensions' => array(), 'cacheResult' => false);
     $args = array_slice($argv, 1);
     for ($i = 0; $i < count($args); $i++) {
         $arg = $args[$i];
@@ -300,6 +302,18 @@ function phpunitArgsPhp(functionName: string, logFunction: string): string {
             $arguments['verbose'] = true;
             continue;
         }
+        if ($arg === '--cache-result-file' && isset($args[$i + 1]) && $args[$i + 1] !== '') {
+            $arguments['cacheResult'] = true;
+            $arguments['cacheResultFile'] = $args[++$i];
+            ${logFunction}('NOTICE:phpunit result cache redirected to: ' . $arguments['cacheResultFile']);
+            continue;
+        }
+        if (strpos($arg, '--cache-result-file=') === 0 && substr($arg, strlen('--cache-result-file=')) !== '') {
+            $arguments['cacheResult'] = true;
+            $arguments['cacheResultFile'] = substr($arg, strlen('--cache-result-file='));
+            ${logFunction}('NOTICE:phpunit result cache redirected to: ' . $arguments['cacheResultFile']);
+            continue;
+        }
     }
     return $arguments;
 }`

tests/phpunit-project-autoload.test.ts

@@ -321,4 +321,22 @@ const managedModeCode = phpunitRunCode({
 
 assert.ok(managedModeCode.includes("configured PHPUnit harness autoload file is not readable"))
 
+const phpunitArgsFunction = extractPhpFunction(managedModeCode, "wp_codebox_phpunit_args")
+const phpunitArgsProbe = join(mkdtempSync(join(tmpdir(), "wp-codebox-phpunit-cache-args-")), "probe.php")
+writeFileSync(phpunitArgsProbe, `<?php
+function pg_log($message) {}
+${phpunitArgsFunction}
+echo json_encode(array(
+  'default' => wp_codebox_phpunit_args(array('phpunit')),
+  'redirected' => wp_codebox_phpunit_args(array('phpunit', '--cache-result-file=/tmp/wp-codebox-phpunit.result.cache')),
+));
+`)
+const phpunitArgs = JSON.parse(execFileSync("php", [phpunitArgsProbe], { encoding: "utf8" })) as {
+  default: Record<string, unknown>
+  redirected: Record<string, unknown>
+}
+assert.equal(phpunitArgs.default.cacheResult, false, "PHPUnit result caching must be disabled when no sandbox cache path is requested")
+assert.equal(phpunitArgs.redirected.cacheResult, true)
+assert.equal(phpunitArgs.redirected.cacheResultFile, "/tmp/wp-codebox-phpunit.result.cache")
+
 console.log("phpunit project autoload ok")