Guard editor state capture stores (#1741)

Author: chubes4

packages/runtime-playground/src/editor-command-runners.ts

@@ -1070,11 +1070,14 @@ async function executeEditorActionStep(page: import("playwright").Page, step: Ed
       return { state: await page.evaluate(() => {
         const wpData = (window as unknown as { wp?: { data?: { select?: (store: string) => Record<string, unknown> } } }).wp?.data
         const select = wpData?.select
-        if (!select) {
+        if (typeof select !== "function") {
           return { storesAvailable: false }
         }
         const editor = select("core/editor")
         const blockEditor = select("core/block-editor")
+        if (!editor || !blockEditor) {
+          return { storesAvailable: false }
+        }
         const currentPost = typeof editor.getCurrentPost === "function" ? editor.getCurrentPost() as Record<string, unknown> | null : null
         const blocks = typeof blockEditor.getBlocks === "function" ? blockEditor.getBlocks() as Array<Record<string, unknown>> : []
         return {
@@ -1147,6 +1150,9 @@ async function saveEditorPost(page: import("playwright").Page, step: Extract<Edi
     const editor = select("core/editor")
     const blockEditor = dispatch("core/block-editor")
     const editorDispatch = dispatch("core/editor")
+    if (!editor) {
+      throw new Error("wp-codebox-editor-readiness-unavailable: core/editor store is unavailable")
+    }
     if (typeof editorDispatch?.savePost !== "function") {
       throw new Error("wp-codebox-editor-save-unsupported: core/editor savePost is unavailable")
     }
@@ -1265,15 +1271,18 @@ interface EditorValidityArtifact {
   summary: BrowserEditorValiditySummary
 }
 
-async function captureEditorState(page: import("playwright").Page, target: ReturnType<typeof editorOpenTargetFromArgs>): Promise<EditorStateSnapshot> {
+export async function captureEditorState(page: import("playwright").Page, target: ReturnType<typeof editorOpenTargetFromArgs>): Promise<EditorStateSnapshot> {
   const state = await page.evaluate(() => {
     const wpData = (window as unknown as { wp?: { data?: { select?: (store: string) => Record<string, unknown> } } }).wp?.data
     const select = wpData?.select
-    if (!select) {
+    if (typeof select !== "function") {
       return { storesAvailable: false }
     }
     const editor = select("core/editor")
     const blockEditor = select("core/block-editor")
+    if (!editor || !blockEditor) {
+      return { storesAvailable: false }
+    }
     const currentPost = typeof editor.getCurrentPost === "function" ? editor.getCurrentPost() as Record<string, unknown> | null : null
     const blocks = typeof blockEditor.getBlocks === "function" ? blockEditor.getBlocks() as Array<Record<string, unknown>> : []
     return {

tests/editor-actions.test.ts

@@ -1,5 +1,5 @@
 import assert from "node:assert/strict"
-import { captureEditorValidity, editorOpenArtifactFilesForCapture, editorOpenArtifactPathPrefixFromArgs } from "../packages/runtime-playground/src/editor-command-runners.js"
+import { captureEditorState, captureEditorValidity, editorOpenArtifactFilesForCapture, editorOpenArtifactPathPrefixFromArgs } from "../packages/runtime-playground/src/editor-command-runners.js"
 import { editorActionStepsFromArgs, editorOpenTargetFromArgs, resolveEditorOpenTarget } from "../packages/runtime-playground/src/editor-actions.js"
 
 const steps = await editorActionStepsFromArgs([
@@ -24,6 +24,25 @@ await assert.rejects(
 )
 
 const target = editorOpenTargetFromArgs(["target=post-new"])
+const unavailableEditorState = await captureEditorState({
+  evaluate: async (callback: () => unknown) => {
+    const globals = globalThis as typeof globalThis & { window?: unknown }
+    const previousWindow = globals.window
+    globals.window = {
+      data: {
+        select: (store: string) => store === "core/block-editor" ? { getBlocks: () => [] } : undefined,
+      },
+    }
+    globals.window = { wp: globals.window }
+    try {
+      return callback()
+    } finally {
+      globals.window = previousWindow
+    }
+  },
+} as never, target)
+assert.equal(unavailableEditorState.storesAvailable, false)
+
 const validity = await captureEditorValidity({
   evaluate: async (_callback: unknown, selectors: string[]) => ([{
     source: "dom",