Terminate poisoned Playground workers

Author: chubes4

package.json

@@ -125,6 +125,7 @@
     "test:playground-custom-archive-cache": "tsx tests/playground-custom-archive-cache.test.ts && tsx tests/playground-custom-archive-cache-process.test.ts && tsx tests/playground-custom-archive-cache.integration.test.ts",
     "test:phpunit-runtime-failure-diagnostics": "tsx tests/phpunit-runtime-failure-diagnostics.test.ts",
     "test:phpunit-runtime-rejection": "tsx tests/phpunit-runtime-rejection.test.ts",
+    "test:playground-worker-runtime-rejection": "tsx tests/playground-worker-runtime-rejection.test.ts",
     "test:php-wasm-extension-manifests": "tsx tests/php-wasm-extension-manifests.test.ts",
     "test:browser-task-builder": "tsx tests/browser-task-builder.test.ts",
     "test:browser-runtime-generic-invoker": "tsx tests/browser-runtime-generic-invoker.test.ts",

patches/@wp-playground+cli+3.1.46.patch

@@ -0,0 +1,24 @@
+diff --git a/node_modules/@wp-playground/cli/worker-thread-v1.js b/node_modules/@wp-playground/cli/worker-thread-v1.js
+index 93b7099..63e96bc 100644
+--- a/node_modules/@wp-playground/cli/worker-thread-v1.js
++++ b/node_modules/@wp-playground/cli/worker-thread-v1.js
+@@ -157,6 +157,7 @@ async function C(r, e) {
+ }
+ process.on("unhandledRejection", (r) => {
+   S.error("Unhandled rejection:", r);
++  throw r;
+ });
+ const i = new _(), [c, p] = y(
+   new F(new f()),
+diff --git a/node_modules/@wp-playground/cli/worker-thread-v2.js b/node_modules/@wp-playground/cli/worker-thread-v2.js
+index fb79a59..5d09b1f 100644
+--- a/node_modules/@wp-playground/cli/worker-thread-v2.js
++++ b/node_modules/@wp-playground/cli/worker-thread-v2.js
+@@ -168,6 +168,7 @@ async function j(r, e) {
+ }
+ process.on("unhandledRejection", (r) => {
+   E.error("Unhandled rejection:", r);
++  throw r;
+ });
+ const i = new m(), [h, u] = k(
+   new L(new b()),

patches/README.md

@@ -8,3 +8,9 @@ WP Codebox needs the repaired bounded Range decoder for the Cloudflare dev rig
 and browser asset path before that upstream change can be merged and released.
 Remove this patch and the package override after a published Playground package
 contains the same change.
+
+`@wp-playground+cli+3.1.46.patch` makes blueprint worker threads rethrow
+unhandled runtime rejections after logging them. The released CLI otherwise
+keeps a poisoned PHP-WASM worker alive and leaves the parent request pending
+until the recipe timeout. Remove the patch after the Playground CLI ships the
+same worker terminalization behavior.

tests/playground-worker-runtime-rejection.test.ts

@@ -0,0 +1,58 @@
+import assert from "node:assert/strict"
+import { mkdtemp, rm, writeFile } from "node:fs/promises"
+import { tmpdir } from "node:os"
+import { join, resolve } from "node:path"
+import { pathToFileURL } from "node:url"
+import { Worker } from "node:worker_threads"
+
+const root = await mkdtemp(join(tmpdir(), "wp-codebox-playground-worker-rejection-"))
+const preloadPath = join(root, "reject-on-command.mjs")
+
+await writeFile(preloadPath, `
+import { parentPort } from "node:worker_threads"
+parentPort?.on("message", (message) => {
+  if (message !== "wp-codebox-trigger-runtime-rejection") return
+  const error = new WebAssembly.RuntimeError("null function or function signature mismatch")
+  error.stack = "RuntimeError: null function or function signature mismatch\\n    at php.wasm.zif_mysqli_poll (wasm://wasm/php.wasm-05996276:wasm-function[12986]:0x9949a8)"
+  Promise.reject(error)
+})
+`, "utf8")
+
+try {
+  for (const version of ["v1", "v2"]) {
+    await assertWorkerTerminates(version)
+  }
+} finally {
+  await rm(root, { recursive: true, force: true })
+}
+
+async function assertWorkerTerminates(version: string): Promise<void> {
+  const workerPath = resolve(`node_modules/@wp-playground/cli/worker-thread-${version}.js`)
+  const worker = new Worker(pathToFileURL(workerPath), {
+    execArgv: ["--import", pathToFileURL(preloadPath).href],
+  })
+
+  let workerError: Error | undefined
+  const exitCode = await Promise.race([
+    new Promise<number>((resolveExit) => {
+      worker.once("message", (message: { command?: unknown; phpPort?: { close?: () => void } }) => {
+        if (message?.command !== "worker-script-initialized") return
+        message.phpPort?.close?.()
+        worker.postMessage("wp-codebox-trigger-runtime-rejection")
+      })
+      worker.once("error", (error) => {
+        workerError = error
+      })
+      worker.once("exit", resolveExit)
+    }),
+    new Promise<never>((_resolve, reject) => {
+      setTimeout(() => reject(new Error(`Playground ${version} worker remained alive after an unhandled runtime rejection`)), 3_000).unref()
+    }),
+  ]).finally(() => worker.terminate())
+
+  assert.notEqual(exitCode, 0, `Playground ${version} worker must exit nonzero after an unhandled runtime rejection`)
+  assert.ok(workerError, `Playground ${version} worker must propagate its unhandled runtime rejection`)
+  assert.match(workerError.message, /null function or function signature mismatch/)
+}
+
+console.log("playground worker runtime rejection terminalization ok")