fix: preserve passwordless database worker isolation

Author: chubes4

packages/runtime-playground/src/playground-cli-runner.ts

@@ -80,7 +80,7 @@ export async function startPlaygroundCliServer(spec: RuntimeCreateSpec, mounts:
     const wordpressInstallMode = spec.environment.wordpressInstallMode ?? "install-from-existing-files"
     const bootstrapIniEntries = runtimeBootstrapPhpIniEntries(spec)
     const useProgrammaticRunner = shouldUseProgrammaticPlaygroundRunner(spec, options)
-    const requestWorkerEndpoint = useProgrammaticRunner || spec.environment.databaseSetup === "external" ? undefined : {
+    const requestWorkerEndpoint = useProgrammaticRunner || connectorSecretPassword(spec) !== undefined ? undefined : {
       route: `/wp-codebox-execute-${randomBytes(12).toString("hex")}.php`,
       token: randomBytes(32).toString("base64url"),
       payloadDirectory: join(spec.artifactsDirectory ?? "artifacts", "playground-internal-shared"),
@@ -480,7 +480,7 @@ require_once ABSPATH . 'wp-settings.php';
 }
 
 function withConnectorSecretEnvironment(server: PlaygroundCliServer, spec: RuntimeCreateSpec): PlaygroundCliServer {
-  const password = spec.environment.databaseSetup === "external" ? spec.secretEnv?.DB_PASSWORD : undefined
+  const password = connectorSecretPassword(spec)
   if (password === undefined) return server
   return {
     ...server,
@@ -493,6 +493,10 @@ function withConnectorSecretEnvironment(server: PlaygroundCliServer, spec: Runti
   }
 }
 
+function connectorSecretPassword(spec: RuntimeCreateSpec): string | undefined {
+  return spec.environment.databaseSetup === "external" ? spec.secretEnv?.DB_PASSWORD : undefined
+}
+
 function distributionBootstrapPhp(spec: RuntimeCreateSpec): string {
   const distribution = recipeDistribution(spec)
   if (!distribution) {

tests/playground-cli-runner-bootstrap-ini.test.ts

@@ -103,6 +103,12 @@ try {
   assert.match(externalWpConfig, /define\('DB_PASSWORD', \(string\) getenv\('DB_PASSWORD'\)\)/)
   assert.doesNotMatch(externalWpConfig, /secret/)
 
+  calls.length = 0
+  const passwordlessExternalServer = await startPlaygroundCliServer({ ...spec, secretEnv: {} }, [], { cliModule })
+  await passwordlessExternalServer[Symbol.asyncDispose]()
+  assert.equal(calls[0]?.["mount-before-install"]?.some((mount) => mount.vfsPath === "/internal/wp-codebox"), true, "passwordless external databases retain isolated request workers")
+  assert.equal(calls[0]?.["mount-before-install"]?.some((mount) => /^\/wordpress\/wp-codebox-execute-[a-f0-9]{24}\.php$/.test(mount.vfsPath)), true)
+
   calls.length = 0
   const defaultRuntimeIniSpec: RuntimeCreateSpec = {
     ...spec,