Disable browser-request cron scheduling

Author: chubes4

packages/runtime-cloudflare/README.md

@@ -18,7 +18,7 @@ The bundled MDI source is pinned to immutable commit `1870fb41279e7eb5946e506c9c
 
 The WordPress server corpus is a separate deployment artifact, never a Worker-module import. `generate:cloudflare-wordpress-runtime-corpus` uses bounded ZIP Range decoding against the pinned WordPress release, retains only `isWordPressRuntimeFile()` entries, and emits a deterministic ZIP under `artifacts/` plus the checked-in `assets/wordpress-runtime-artifact.json` provenance manifest. The immutable R2 key is derived from the corpus ZIP SHA-256. Cold boot fetches that exact object through `WORDPRESS_STATE_BUCKET`, validates the manifest and archive/file hashes and budgets, then streams it into PHP MEMFS. Static browser assets continue to use lazy exact archive ranges and Worker cache.
 
-Canonical Cloudflare boots patch only the assembled PHP MEMFS copy of `/wordpress/wp-settings.php` after the R2 WordPress corpus is materialized and before WordPress executes. The patch requires exactly one canonical `do_action( 'init' );` needle, fails closed otherwise, removes only core's `wp_cron` callback through public `remove_action()` when `DISABLE_WP_CRON` is true, then executes the original `init` call once. Cron spawning is explicitly disabled by this runtime policy because the PHP-WASM/MDI shutdown callback path is not supported. Update and privacy scheduling callbacks remain registered; an explicit durable cron execution contract is separate future scope.
+Canonical Cloudflare boots patch only the assembled PHP MEMFS copy of `/wordpress/wp-settings.php` after the R2 WordPress corpus is materialized and before WordPress executes. The disabled-cron scheduling policy requires exactly one canonical `do_action( 'init' );` needle and fails closed otherwise. When `DISABLE_WP_CRON` is true, it removes only core's `wp_cron`, `wp_schedule_delete_old_privacy_export_files`, and `wp_schedule_update_checks` callbacks through public `remove_action()` before executing the original `init` call once. This prevents browser requests from recreating cron work that cannot execute in the PHP-WASM/MDI shutdown path. Durable cron execution belongs to a separate explicit queue or scheduled-Worker contract.
 
 ## MDI Init Diagnostics
 

packages/runtime-cloudflare/src/worker.ts

@@ -1003,7 +1003,7 @@ async function bootWordPressRuntime(
   siteUrl = SITE_URL,
   authConstants: Partial<Record<WordPressAuthConstant, string>> = {},
   runtimeBucket?: R2Bucket,
-  shouldPatchCanonicalCronAtInit = false,
+  shouldPatchCanonicalDisabledCronSchedulingPolicyAtInit = false,
 ): Promise<{ php: PHP; requestHandler: PHPRequestHandler; wordpressVersion: string }> {
   const requestHandler = await bootWordPressAndRequestHandler({
     createPhpRuntime,
@@ -1035,7 +1035,7 @@ async function bootWordPressRuntime(
           materializeRuntimeFiles(php, MARKDOWN_ROOT, markdownFiles)
           if (markdownIndexSeed) php.writeFile(MARKDOWN_RESOLVED_INDEX_PATH, markdownIndexSeed)
         }
-        if (shouldPatchCanonicalCronAtInit) patchCanonicalCronAtInit(php)
+        if (shouldPatchCanonicalDisabledCronSchedulingPolicyAtInit) patchCanonicalDisabledCronSchedulingPolicyAtInit(php)
       } : undefined,
       beforeDatabaseSetup: databaseSeed ? (php: PHP) => {
         php.mkdir("/wordpress/wp-content/database")
@@ -1063,16 +1063,18 @@ function materializeRuntimeFiles(php: PHP, root: string, files: RuntimeFile[]):
   }
 }
 
-function patchCanonicalCronAtInit(php: PHP): void {
+function patchCanonicalDisabledCronSchedulingPolicyAtInit(php: PHP): void {
   const settingsPath = "/wordpress/wp-settings.php"
   const needle = "do_action( 'init' );"
   const settings = new TextDecoder().decode(php.readFileAsBuffer(settingsPath))
   const firstNeedle = settings.indexOf(needle)
   if (firstNeedle === -1 || firstNeedle !== settings.lastIndexOf(needle)) {
-    throw new Error("WordPress canonical cron patch needle was not uniquely found.")
+    throw new Error("WordPress canonical disabled-cron scheduling policy patch needle was not uniquely found.")
   }
   const replacement = `if ( defined( 'DISABLE_WP_CRON' ) && DISABLE_WP_CRON ) {
 	remove_action( 'init', 'wp_cron' );
+	remove_action( 'init', 'wp_schedule_delete_old_privacy_export_files' );
+	remove_action( 'init', 'wp_schedule_update_checks' );
 }
 ${needle}`
   php.writeFile(settingsPath, new TextEncoder().encode(`${settings.slice(0, firstNeedle)}${replacement}${settings.slice(firstNeedle + needle.length)}`))

scripts/cloudflare-local-gate.mjs

@@ -172,14 +172,14 @@ async function assertCanonicalProbes() {
   const wordpress = await (await request(`${origin}/?phase=canonical-wordpress`)).json()
   const setup = await (await request(`${origin}/?phase=canonical-bootstrap-setup`)).json()
   const counts = ["canonicalSeedFiles", "postCount", "pageCount", "userCount", "optionCount", "widgetOptionCount", "widgetStateOptionCount", "memoryBytes", "peakMemoryBytes"]
-  if (wordpress.completed !== true || typeof wordpress.evidence?.wordpressVersion !== "string" || counts.some((key) => !Number.isInteger(wordpress.evidence?.[key])) || wordpress.evidence.widgetStateOptionCount !== 19 || wordpress.evidence.wpCronInitAttached !== false || wordpress.evidence.updateScheduleInitAttached !== true || wordpress.evidence.privacyScheduleInitAttached !== true) {
+  if (wordpress.completed !== true || typeof wordpress.evidence?.wordpressVersion !== "string" || counts.some((key) => !Number.isInteger(wordpress.evidence?.[key])) || wordpress.evidence.widgetStateOptionCount !== 19 || wordpress.evidence.wpCronInitAttached !== false || wordpress.evidence.updateScheduleInitAttached !== false || wordpress.evidence.privacyScheduleInitAttached !== false) {
     throw new Error(`Canonical WordPress probe did not boot the complete seed: ${JSON.stringify(wordpress)}`)
   }
   const changedCounts = ["createdPathCount", "changedPathCount", "deletedPathCount"]
   if (setup.completed !== true || typeof setup.evidence?.wordpressVersion !== "string" || changedCounts.some((key) => !Number.isInteger(setup.evidence?.[key])) || setup.evidence.changedPathCount < 1) {
     throw new Error(`Canonical bootstrap setup probe did not produce ephemeral changes: ${JSON.stringify(setup)}`)
   }
-  console.log(`Canonical probes: WordPress ${wordpress.evidence.wordpressVersion}, cron init disabled while update/privacy scheduling remain registered, ${wordpress.evidence.widgetOptionCount} widget_* options plus sidebars_widgets, ${setup.evidence.changedPathCount} changed ephemeral paths.`)
+  console.log(`Canonical probes: WordPress ${wordpress.evidence.wordpressVersion}, disabled-cron scheduling callbacks absent at init, ${wordpress.evidence.widgetOptionCount} widget_* options plus sidebars_widgets, ${setup.evidence.changedPathCount} changed ephemeral paths.`)
 }
 
 async function assertMdiDiagnostics() {

tests/cloudflare-runtime.test.ts

@@ -313,22 +313,24 @@ test("Cloudflare MDI lifecycle diagnostics use the complete packaged seed withou
   assert.match(worker, /function canonicalChangedPathCounts/)
 })
 
-test("Cloudflare canonical runtime patches the unique init call in MEMFS without removing other scheduling callbacks", async () => {
+test("Cloudflare canonical runtime patches the unique init call with the disabled-cron scheduling policy", async () => {
   const worker = await readFile(new URL("../packages/runtime-cloudflare/src/worker.ts", import.meta.url), "utf8")
-  const patcher = worker.slice(worker.indexOf("function patchCanonicalCronAtInit"), worker.indexOf("\nfunction collectRuntimeFiles"))
+  const patcher = worker.slice(worker.indexOf("function patchCanonicalDisabledCronSchedulingPolicyAtInit"), worker.indexOf("\nfunction collectRuntimeFiles"))
 
-  assert.ok(patcher.startsWith("function patchCanonicalCronAtInit"), "The canonical cron init patcher is present.")
+  assert.ok(patcher.startsWith("function patchCanonicalDisabledCronSchedulingPolicyAtInit"), "The canonical disabled-cron scheduling policy patcher is present.")
   assert.match(patcher, /const settingsPath = "\/wordpress\/wp-settings\.php"/)
   assert.match(patcher, /php\.readFileAsBuffer\(settingsPath\)/)
   assert.match(patcher, /firstNeedle === -1 \|\| firstNeedle !== settings\.lastIndexOf\(needle\)/)
-  assert.match(patcher, /throw new Error\("WordPress canonical cron patch needle was not uniquely found\."\)/)
+  assert.match(patcher, /throw new Error\("WordPress canonical disabled-cron scheduling policy patch needle was not uniquely found\."\)/)
   assert.match(patcher, /defined\( 'DISABLE_WP_CRON' \) && DISABLE_WP_CRON/)
   assert.match(patcher, /remove_action\( 'init', 'wp_cron' \)/)
+  assert.match(patcher, /remove_action\( 'init', 'wp_schedule_delete_old_privacy_export_files' \)/)
+  assert.match(patcher, /remove_action\( 'init', 'wp_schedule_update_checks' \)/)
   assert.equal((patcher.match(/do_action\( 'init' \);/g) ?? []).length, 1)
   assert.match(patcher, /php\.writeFile\(settingsPath/)
-  assert.doesNotMatch(patcher, /mu-plugins|add_action\(|wp_schedule_update_checks|wp_schedule_delete_old_privacy_export_files|\$GLOBALS\['wp_filter'\]/)
+  assert.doesNotMatch(patcher, /mu-plugins|add_action\(|WP_Site_Health|wp_schedule_site_health_cron|\$GLOBALS\['wp_filter'\]/)
   assert.doesNotMatch(worker, /materializeCanonicalCronAdapter|wp-codebox-canonical-cron-policy/)
-  assert.match(worker, /runtimeBucket\?: R2Bucket,\n  shouldPatchCanonicalCronAtInit = false,/)
+  assert.match(worker, /runtimeBucket\?: R2Bucket,\n  shouldPatchCanonicalDisabledCronSchedulingPolicyAtInit = false,/)
   assert.match(worker, /authConstants, bucket, true\), pointer/)
   assert.match(worker, /env\.WORDPRESS_STATE_BUCKET, true\)/)
   assert.match(worker, /canonical-probe\.invalid", \{\}, bucket, true\)/)