Navigate multi-actor browser sessions (#1948)

Author: chubes4

packages/runtime-playground/src/browser-multi-actor-scenario-runner.ts

@@ -1,3 +1,4 @@
+import type { Page } from "playwright"
 import { type BrowserMultiActorScenario, type RuntimeCreateSpec } from "@automattic/wp-codebox-core"
 import { now } from "@automattic/wp-codebox-core/internals"
 import { BrowserArtifactSession } from "./browser-artifact-session.js"
@@ -35,6 +36,7 @@ export async function runBrowserMultiActorScenarioCommand(input: {
 
   try {
     const clientEntries: Array<[string, BrowserMultiActorClient]> = []
+    const actorPages: Array<{ actor: string; page: Pick<Page, "goto"> }> = []
     // Playground PHP commands share one runtime endpoint, so provision identities
     // and install cookies serially before actions begin concurrently.
     for (const actor of scenario.actors) {
@@ -50,8 +52,10 @@ export async function runBrowserMultiActorScenarioCommand(input: {
       const networkTasks: Array<Promise<void>> = []
       attachBrowserCaptureListeners({ captureConsole: captures.has("console"), captureErrors: captures.has("errors"), captureNetwork: true, consoleMessages: actorEvidence.console, errors: actorEvidence.errors, network: actorEvidence.network, networkTasks, page })
       clientEntries.push([actor.name, actorClient({ actor: actor.name, artifacts, captures, context, evidence: actorEvidence, networkTasks, page, scenario, previewOrigin: topology.preview.effectiveOrigin })])
+      actorPages.push({ actor: actor.name, page })
     }
     const clients = Object.fromEntries(clientEntries)
+    await navigateBrowserMultiActorPages(actorPages, topology.resolveUrl(scenario.url))
     result = await runBrowserMultiActorScenario(scenario, clients)
   } catch (error) {
     failure = error instanceof Error ? error : new Error(String(error))
@@ -78,6 +82,20 @@ export async function runBrowserMultiActorScenarioCommand(input: {
   return { artifact, output: `${JSON.stringify({ command: "wordpress.browser-scenario", files: artifact.files, summary: artifact.summary, scenario: summary }, null, 2)}\n` }
 }
 
+export async function navigateBrowserMultiActorPages(
+  actorPages: Array<{ actor: string; page: Pick<Page, "goto"> }>,
+  url: string,
+): Promise<void> {
+  await Promise.all(actorPages.map(async ({ actor, page }) => {
+    try {
+      await page.goto(url, { waitUntil: "load" })
+    } catch (error) {
+      const message = error instanceof Error ? error.message : String(error)
+      throw new Error(`Actor ${actor} failed to navigate to ${url}: ${message}`)
+    }
+  }))
+}
+
 interface ActorEvidence {
   console: Record<string, unknown>[]
   errors: BrowserProbeErrorRecord[]

tests/browser-multi-actor-scenario.test.ts

@@ -1,6 +1,29 @@
 import assert from "node:assert/strict"
 import { BROWSER_MULTI_ACTOR_SCENARIO_SCHEMA, type BrowserMultiActorScenario } from "../packages/runtime-core/src/browser-multi-actor-scenario-contracts.js"
 import { BrowserMultiActorScenarioError, runBrowserMultiActorScenario, type BrowserMultiActorClient } from "../packages/runtime-playground/src/browser-multi-actor-scenario.js"
+import { navigateBrowserMultiActorPages } from "../packages/runtime-playground/src/browser-multi-actor-scenario-runner.js"
+
+const navigationStarted: string[] = []
+let releaseNavigation!: () => void
+const navigationRelease = new Promise<void>((resolve) => { releaseNavigation = resolve })
+const navigation = navigateBrowserMultiActorPages([
+  { actor: "author", page: { async goto(url) { navigationStarted.push(`author:${url}`); await navigationRelease; return null } } },
+  { actor: "reviewer", page: { async goto(url) { navigationStarted.push(`reviewer:${url}`); await navigationRelease; return null } } },
+], "https://example.test/wp-admin/post.php?post=1&action=edit")
+await new Promise((resolve) => setTimeout(resolve, 0))
+assert.deepEqual(navigationStarted, [
+  "author:https://example.test/wp-admin/post.php?post=1&action=edit",
+  "reviewer:https://example.test/wp-admin/post.php?post=1&action=edit",
+])
+releaseNavigation()
+await navigation
+
+await assert.rejects(
+  navigateBrowserMultiActorPages([
+    { actor: "reviewer", page: { async goto() { throw new Error("net::ERR_FAILED") } } },
+  ], "https://example.test/editor"),
+  /Actor reviewer failed to navigate to https:\/\/example\.test\/editor: net::ERR_FAILED/,
+)
 
 const closed: string[] = []
 const actions: string[] = []