fix: defer MySQL multisite setup to PHPUnit

Author: chubes4

packages/runtime-core/src/recipe-builders.ts

@@ -82,7 +82,7 @@ export function buildWordPressPhpunitRecipe(options: WordPressPhpunitRecipeOptio
       wp: options.wordpressVersion ?? DEFAULT_WORDPRESS_VERSION,
       ...(options.phpVersion ? { phpVersion: options.phpVersion } : {}),
       ...(options.wordpressInstallMode ? { wordpressInstallMode: options.wordpressInstallMode } : {}),
-      blueprint: blueprintWithMultisite(options.blueprint ?? { steps: [] }, options.multisite ?? false),
+      blueprint: blueprintWithMultisite(options.blueprint ?? { steps: [] }, (options.multisite ?? false) && options.databaseType !== "mysql"),
       ...(options.preview || options.multisite ? { preview: multisitePreview(options.preview, options.multisite ?? false) } : {}),
       ...(options.extensions?.length ? { extensions: options.extensions } : {}),
       ...(options.backendPackage ? { backendPackage: options.backendPackage } : {}),

packages/runtime-playground/src/playground-cli-runner.ts

@@ -460,8 +460,6 @@ function externalDatabaseWpConfig(spec: RuntimeCreateSpec): string | undefined {
   const host = spec.runtimeEnv?.DB_HOST
   if (!host) return undefined
   const port = spec.runtimeEnv?.DB_PORT
-  const multisite = blueprintEnablesMultisite(spec.environment.blueprint)
-  const multisiteSite = multisiteSiteIdentity(spec.preview?.siteUrl)
   const values = {
     DB_NAME: spec.runtimeEnv?.DB_NAME ?? "runtime",
     DB_USER: spec.runtimeEnv?.DB_USER ?? "root",
@@ -476,33 +474,11 @@ define('DB_HOST', ${phpLiteral(values.DB_HOST)});
 define('DB_CHARSET', 'utf8mb4');
 define('DB_COLLATE', '');
 $table_prefix = 'wp_';
-${multisite ? `define('MULTISITE', true);
-define('SUBDOMAIN_INSTALL', false);
-define('DOMAIN_CURRENT_SITE', ${phpLiteral(multisiteSite.domain)});
-define('PATH_CURRENT_SITE', ${phpLiteral(multisiteSite.path)});
-define('SITE_ID_CURRENT_SITE', 1);
-define('BLOG_ID_CURRENT_SITE', 1);
-` : ""}if (!defined('ABSPATH')) define('ABSPATH', __DIR__ . '/');
+if (!defined('ABSPATH')) define('ABSPATH', __DIR__ . '/');
 require_once ABSPATH . 'wp-settings.php';
 `
 }
 
-function blueprintEnablesMultisite(blueprint: unknown): boolean {
-  if (!blueprint || typeof blueprint !== "object" || Array.isArray(blueprint)) return false
-  const steps = Array.isArray((blueprint as { steps?: unknown }).steps) ? (blueprint as { steps: unknown[] }).steps : []
-  return steps.some((step) => Boolean(step && typeof step === "object" && !Array.isArray(step) && (step as { step?: unknown }).step === "enableMultisite"))
-}
-
-function multisiteSiteIdentity(siteUrl?: string): { domain: string; path: string } {
-  try {
-    const url = new URL(siteUrl || "http://localhost")
-    const path = `/${url.pathname.replace(/^\/+|\/+$/g, "")}`
-    return { domain: url.hostname || "localhost", path: path === "/" ? path : `${path}/` }
-  } catch {
-    return { domain: "localhost", path: "/" }
-  }
-}
-
 function distributionBootstrapPhp(spec: RuntimeCreateSpec): string {
   const distribution = recipeDistribution(spec)
   if (!distribution) {

tests/phpunit-project-autoload.test.ts

@@ -770,6 +770,14 @@ assert.deepEqual((multisiteRecipe.runtime.blueprint as { steps: unknown[] }).ste
 assert.equal(multisiteRecipe.runtime.preview?.siteUrl, "http://localhost", "multisite PHPUnit recipes need a canonical site URL without the dynamic Playground port")
 assert.ok(multisiteRecipe.workflow.steps[0].args.includes("multisite=1"))
 
+const externalMysqlMultisiteRecipe = buildWordPressPhpunitRecipe({
+  pluginSlug: "network-plugin",
+  databaseType: "mysql",
+  multisite: true,
+})
+assert.deepEqual((externalMysqlMultisiteRecipe.runtime.blueprint as { steps: unknown[] }).steps, [], "external MySQL must boot single-site until the managed PHPUnit installer creates network tables")
+assert.ok(externalMysqlMultisiteRecipe.workflow.steps[0].args.includes("multisite=1"), "managed PHPUnit still receives the declared multisite contract")
+
 const phpunitCacheAllocator = extractPhpFunction(managedModeCode, "wp_codebox_phpunit_args_private_cache_result_file")
 const phpunitArgsFunction = extractPhpFunction(managedModeCode, "wp_codebox_phpunit_args")
 const phpunitArgsProbe = join(mkdtempSync(join(tmpdir(), "wp-codebox-phpunit-cache-args-")), "probe.php")

tests/playground-cli-runner-bootstrap-ini.test.ts

@@ -103,21 +103,6 @@ try {
   const externalWpConfig = await readFile(externalWpConfigPath as string, "utf8")
   assert.match(externalWpConfig, /define\('DB_HOST', "127\.0\.0\.1:33061"\)/)
   assert.match(externalWpConfig, /define\('DB_PASSWORD', "secret"\)/)
-  assert.doesNotMatch(externalWpConfig, /define\('MULTISITE'/)
-
-  calls.length = 0
-  const externalMultisiteSpec: RuntimeCreateSpec = {
-    ...spec,
-    environment: { ...spec.environment, blueprint: { steps: [{ step: "enableMultisite" }] } },
-  }
-  const externalMultisiteServer = await startPlaygroundCliServer(externalMultisiteSpec, [], { cliModule })
-  await externalMultisiteServer[Symbol.asyncDispose]()
-  const externalMultisiteConfigPath = calls[0]["mount-before-install"]?.find((mount) => mount.vfsPath === "/wordpress/wp-config.php")?.hostPath
-  assert.equal(typeof externalMultisiteConfigPath, "string")
-  const externalMultisiteConfig = await readFile(externalMultisiteConfigPath as string, "utf8")
-  assert.match(externalMultisiteConfig, /define\('MULTISITE', true\)/)
-  assert.match(externalMultisiteConfig, /define\('SUBDOMAIN_INSTALL', false\)/)
-  assert.match(externalMultisiteConfig, /define\('DOMAIN_CURRENT_SITE', "localhost"\)/)
 
   calls.length = 0
   const defaultRuntimeIniSpec: RuntimeCreateSpec = {