fix: preserve multisite with external MySQL

Author: chubes4

packages/runtime-playground/src/playground-cli-runner.ts

@@ -460,6 +460,8 @@ function externalDatabaseWpConfig(spec: RuntimeCreateSpec): string | undefined {
   const host = spec.runtimeEnv?.DB_HOST
   if (!host) return undefined
   const port = spec.runtimeEnv?.DB_PORT
+  const multisite = blueprintEnablesMultisite(spec.environment.blueprint)
+  const multisiteSite = multisiteSiteIdentity(spec.preview?.siteUrl)
   const values = {
     DB_NAME: spec.runtimeEnv?.DB_NAME ?? "runtime",
     DB_USER: spec.runtimeEnv?.DB_USER ?? "root",
@@ -474,11 +476,33 @@ define('DB_HOST', ${phpLiteral(values.DB_HOST)});
 define('DB_CHARSET', 'utf8mb4');
 define('DB_COLLATE', '');
 $table_prefix = 'wp_';
-if (!defined('ABSPATH')) define('ABSPATH', __DIR__ . '/');
+${multisite ? `define('MULTISITE', true);
+define('SUBDOMAIN_INSTALL', false);
+define('DOMAIN_CURRENT_SITE', ${phpLiteral(multisiteSite.domain)});
+define('PATH_CURRENT_SITE', ${phpLiteral(multisiteSite.path)});
+define('SITE_ID_CURRENT_SITE', 1);
+define('BLOG_ID_CURRENT_SITE', 1);
+` : ""}if (!defined('ABSPATH')) define('ABSPATH', __DIR__ . '/');
 require_once ABSPATH . 'wp-settings.php';
 `
 }
 
+function blueprintEnablesMultisite(blueprint: unknown): boolean {
+  if (!blueprint || typeof blueprint !== "object" || Array.isArray(blueprint)) return false
+  const steps = Array.isArray((blueprint as { steps?: unknown }).steps) ? (blueprint as { steps: unknown[] }).steps : []
+  return steps.some((step) => Boolean(step && typeof step === "object" && !Array.isArray(step) && (step as { step?: unknown }).step === "enableMultisite"))
+}
+
+function multisiteSiteIdentity(siteUrl?: string): { domain: string; path: string } {
+  try {
+    const url = new URL(siteUrl || "http://localhost")
+    const path = `/${url.pathname.replace(/^\/+|\/+$/g, "")}`
+    return { domain: url.hostname || "localhost", path: path === "/" ? path : `${path}/` }
+  } catch {
+    return { domain: "localhost", path: "/" }
+  }
+}
+
 function distributionBootstrapPhp(spec: RuntimeCreateSpec): string {
   const distribution = recipeDistribution(spec)
   if (!distribution) {

tests/disposable-mysql-mysqli.integration.test.ts

@@ -146,6 +146,61 @@ require_once ABSPATH . 'wp-settings.php';
     assert.deepEqual(aggregate.counts, { total: 2, succeeded: 2, failed: 0, timedOut: 0, cancelled: 0 })
     assert.deepEqual(aggregate.entries.map((entry: { artifactNamespace: string }) => entry.artifactNamespace), ["phpunit/one", "phpunit/two"])
     assert.deepEqual(aggregate.entries.map((entry: { inputIndex: number }) => entry.inputIndex), [0, 1])
+
+    const multisitePlugin = join(directory, "managed-multisite-fixture")
+    const multisiteRecipePath = join(directory, "managed-multisite-recipe.json")
+    await mkdir(join(multisitePlugin, "tests"), { recursive: true })
+    await writeFile(join(multisitePlugin, "managed-multisite-fixture.php"), `<?php
+/** Plugin Name: Managed Multisite Fixture */
+add_action('init', static function (): void {
+    update_option('wp_codebox_parent_init_ran', 1);
+    add_action('init', static function (): void {
+        update_option('wp_codebox_nested_init_ran', 1);
+        do_action('wp_codebox_nested_init_replayed');
+    }, 15);
+}, 0);
+`)
+    await writeFile(join(multisitePlugin, "phpunit.xml.dist"), "<?xml version=\"1.0\"?><phpunit><testsuites><testsuite name=\"managed-multisite\"><directory>tests</directory></testsuite></testsuites></phpunit>\n")
+    await writeFile(join(multisitePlugin, "tests", "ManagedMultisiteTest.php"), `<?php
+final class ManagedMultisiteTest extends WP_UnitTestCase {
+    public function test_external_mysql_preserves_multisite_blog_switching(): void {
+        $this->assertTrue(is_multisite());
+        $original = get_current_blog_id();
+        $blog_id = self::factory()->blog->create();
+        switch_to_blog($blog_id);
+        $this->assertSame($blog_id, get_current_blog_id());
+        $this->assertTrue(ms_is_switched());
+        restore_current_blog();
+        $this->assertSame($original, get_current_blog_id());
+        $this->assertFalse(ms_is_switched());
+    }
+
+    public function test_external_mysql_replays_wordpress_lifecycle_in_order(): void {
+        $this->assertGreaterThan(0, did_action('init'));
+        $this->assertSame(1, (int) get_option('wp_codebox_parent_init_ran'));
+        $this->assertSame(1, (int) get_option('wp_codebox_nested_init_ran'));
+        $this->assertSame(1, did_action('wp_codebox_nested_init_replayed'));
+    }
+
+    public function test_runtime_uses_real_mysql(): void {
+        global $wpdb;
+        $this->assertInstanceOf(mysqli::class, $wpdb->dbh);
+        $this->assertSame('1', (string) $wpdb->get_var("SELECT JSON_VALID('{\\"valid\\":true}')"));
+    }
+}
+`)
+    const multisiteRecipe = buildWordPressPhpunitRecipe({
+      pluginSlug: "managed-multisite-fixture",
+      phpVersion: "8.3",
+      databaseType: "mysql",
+      multisite: true,
+      pluginSource: multisitePlugin,
+      dependencyMounts: ["/wordpress/wp-content/plugins/managed-multisite-fixture"],
+      mounts: [{ source: join(harness, "vendor"), target: "/wp-codebox-vendor", mode: "readonly" }],
+    })
+    await writeFile(multisiteRecipePath, `${JSON.stringify(multisiteRecipe)}\n`)
+    const multisiteResult = await runRecipe({ recipePath: multisiteRecipePath, previewHoldBlocking: false, previewLeaseRequested: false, previewLeaseChild: false, timeoutMs: 300_000, json: true, summary: false, dryRun: false })
+    assert.equal(multisiteResult.success, true, JSON.stringify(multisiteResult))
     console.log("disposable MySQL and MariaDB mysqli E2E passed")
   } finally {
     await rm(directory, { recursive: true, force: true })

tests/playground-cli-runner-bootstrap-ini.test.ts

@@ -103,6 +103,21 @@ try {
   const externalWpConfig = await readFile(externalWpConfigPath as string, "utf8")
   assert.match(externalWpConfig, /define\('DB_HOST', "127\.0\.0\.1:33061"\)/)
   assert.match(externalWpConfig, /define\('DB_PASSWORD', "secret"\)/)
+  assert.doesNotMatch(externalWpConfig, /define\('MULTISITE'/)
+
+  calls.length = 0
+  const externalMultisiteSpec: RuntimeCreateSpec = {
+    ...spec,
+    environment: { ...spec.environment, blueprint: { steps: [{ step: "enableMultisite" }] } },
+  }
+  const externalMultisiteServer = await startPlaygroundCliServer(externalMultisiteSpec, [], { cliModule })
+  await externalMultisiteServer[Symbol.asyncDispose]()
+  const externalMultisiteConfigPath = calls[0]["mount-before-install"]?.find((mount) => mount.vfsPath === "/wordpress/wp-config.php")?.hostPath
+  assert.equal(typeof externalMultisiteConfigPath, "string")
+  const externalMultisiteConfig = await readFile(externalMultisiteConfigPath as string, "utf8")
+  assert.match(externalMultisiteConfig, /define\('MULTISITE', true\)/)
+  assert.match(externalMultisiteConfig, /define\('SUBDOMAIN_INSTALL', false\)/)
+  assert.match(externalMultisiteConfig, /define\('DOMAIN_CURRENT_SITE', "localhost"\)/)
 
   calls.length = 0
   const defaultRuntimeIniSpec: RuntimeCreateSpec = {