Skip concrete PHPUnit helper classes

Author: chubes4

packages/runtime-playground/src/phpunit-command-handlers.ts

@@ -350,6 +350,20 @@ function ${functionName}(array $argv) {
 }`
 }
 
+function phpunitClassHasTestsPhp(functionName: string): string {
+  return `function ${functionName}(ReflectionClass $class): bool {
+    if ($class->hasMethod('suite') && $class->getMethod('suite')->isStatic()) {
+        return true;
+    }
+    foreach ((new PHPUnit\\Util\\Reflection())->publicMethodsInTestClass($class) as $method) {
+        if (PHPUnit\\Util\\Test::isTestMethod($method)) {
+            return true;
+        }
+    }
+    return false;
+}`
+}
+
 export function phpunitRunCode(options: PhpunitRunCodeOptions): string {
   return `error_reporting(E_ALL);
 ini_set('display_errors', '1');
@@ -1314,10 +1328,11 @@ try {
     exit(1);
 }
 $after_classes = get_declared_classes();
+${phpunitClassHasTestsPhp("pg_phpunit_class_has_tests")}
 foreach (array_diff($after_classes, $before_classes) as $class_name) {
     try {
         $ref = new ReflectionClass($class_name);
-        if (!$ref->isAbstract() && $ref->isSubclassOf('PHPUnit\\Framework\\TestCase')) {
+        if (!$ref->isAbstract() && $ref->isSubclassOf('PHPUnit\\Framework\\TestCase') && pg_phpunit_class_has_tests($ref)) {
             $suite->addTestSuite($ref);
         }
     } catch (Throwable $e) {
@@ -1637,10 +1652,11 @@ try {
     exit(1);
 }
 $after_classes = get_declared_classes();
+${phpunitClassHasTestsPhp("core_pg_phpunit_class_has_tests")}
 foreach (array_diff($after_classes, $before_classes) as $class_name) {
     try {
         $ref = new ReflectionClass($class_name);
-        if (!$ref->isAbstract() && $ref->isSubclassOf('PHPUnit\\Framework\\TestCase')) {
+        if (!$ref->isAbstract() && $ref->isSubclassOf('PHPUnit\\Framework\\TestCase') && core_pg_phpunit_class_has_tests($ref)) {
             $suite->addTestSuite($ref);
         }
     } catch (Throwable $e) {

tests/phpunit-project-autoload.test.ts

@@ -325,7 +325,11 @@ function assertDiscoveredTestExecutes(source: string, stagePrefix: "pg" | "core_
     : `public function __construct($name) { $this->name = $name; }`
 
   writeFileSync(testFile, `<?php
+class ConcreteHelper extends PHPUnit\\Framework\\TestCase {
+    public function helperMethod(): void {}
+}
 class DiscoveredTest extends PHPUnit\\Framework\\TestCase {
+    public function testDiscovered(): void {}
     public function run(): void {
         file_put_contents(getenv('EXECUTION_MARKER'), 'executed');
     }
@@ -339,11 +343,24 @@ final class TestSuite {
     private $name;
     private $tests = array();
     ${testSuiteFactory}
-    public function addTestSuite(\\ReflectionClass $class): void { $this->tests[] = $class->newInstance(); }
+    public function addTestSuite(\\ReflectionClass $class): void {
+        if ($class->getName() === 'ConcreteHelper') { throw new \\RuntimeException('concrete helper was scheduled as a test'); }
+        $this->tests[] = $class->newInstance();
+    }
     public function tests(): array { return $this->tests; }
     public function count(): int { return count($this->tests); }
 }
 }
+namespace PHPUnit\\Util {
+final class Reflection {
+    public function publicMethodsInTestClass(\\ReflectionClass $class): array { return $class->getMethods(\\ReflectionMethod::IS_PUBLIC); }
+}
+final class Test {
+    public static function isTestMethod(\\ReflectionMethod $method): bool {
+        return strpos($method->getName(), 'test') === 0 || strpos((string) $method->getDocComment(), '@test') !== false;
+    }
+}
+}
 namespace PHPUnit\\TextUI {
 final class TestResult {
     private $count;

tests/playground-phpunit-readonly-cache.integration.test.ts

@@ -64,7 +64,7 @@ async function writeFixture(): Promise<void> {
   await writeFile(join(plugin, "readonly-phpunit-fixture.php"), "<?php\n/**\n * Plugin Name: Readonly PHPUnit Fixture\n */\n")
   await writeFile(join(plugin, "phpunit.xml.dist"), "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<phpunit><testsuites><testsuite name=\"readonly-cache\"><directory>tests</directory></testsuite></testsuites></phpunit>\n")
   await writeFile(join(plugin, "source-sentinel.bin"), sentinel)
-  await writeFile(join(plugin, "tests", "ReadonlyCacheTest.php"), "<?php\nclass ReadonlyCacheTest extends WP_UnitTestCase { public function test_multisite_runtime_is_active(): void { $this->assertTrue(is_multisite()); } public function test_sentinel_is_available(): void { $this->assertGreaterThan(0, filesize(dirname(__DIR__) . \'/source-sentinel.bin\')); } public function test_dependency_activation_runs_after_install(): void { $this->assertGreaterThanOrEqual(1, get_option(\'wp_codebox_dependency_activation_users\')); } public function test_dependency_plugins_loaded_runs_once(): void { $this->assertSame(1, (int) get_option(\'wp_codebox_dependency_plugins_loaded_count\')); } public function test_wp_cli_namespaced_stdout_is_available(): void { $this->assertTrue(eval(\'namespace cli; return is_resource(STDOUT);\')); } }\n")
+  await writeFile(join(plugin, "tests", "ReadonlyCacheTest.php"), "<?php\nclass ConcreteTestHelper extends WP_UnitTestCase { public function fixture(): string { return \'fixture\'; } }\nclass ReadonlyCacheTest extends WP_UnitTestCase { public function test_multisite_runtime_is_active(): void { $this->assertTrue(is_multisite()); } public function test_sentinel_is_available(): void { $this->assertGreaterThan(0, filesize(dirname(__DIR__) . \'/source-sentinel.bin\')); } public function test_dependency_activation_runs_after_install(): void { $this->assertGreaterThanOrEqual(1, get_option(\'wp_codebox_dependency_activation_users\')); } public function test_dependency_plugins_loaded_runs_once(): void { $this->assertSame(1, (int) get_option(\'wp_codebox_dependency_plugins_loaded_count\')); } public function test_wp_cli_namespaced_stdout_is_available(): void { $this->assertTrue(eval(\'namespace cli; return is_resource(STDOUT);\')); } }\n")
   await writeFile(join(dependency, "activation-dependency.php"), "<?php\n/**\n * Plugin Name: Activation Dependency\n */\nadd_action('plugins_loaded', static function (): void { update_option('wp_codebox_dependency_plugins_loaded_count', (int) get_option('wp_codebox_dependency_plugins_loaded_count', 0) + 1); });\nregister_activation_hook(__FILE__, static function (): void { update_option('wp_codebox_dependency_activation_users', count(get_users(array('number' => 1)))); });\n")
 }