Patch disabled cron before canonical init

Author: chubes4

packages/runtime-cloudflare/README.md

@@ -18,7 +18,7 @@ The bundled MDI source is pinned to immutable commit `1870fb41279e7eb5946e506c9c
 
 The WordPress server corpus is a separate deployment artifact, never a Worker-module import. `generate:cloudflare-wordpress-runtime-corpus` uses bounded ZIP Range decoding against the pinned WordPress release, retains only `isWordPressRuntimeFile()` entries, and emits a deterministic ZIP under `artifacts/` plus the checked-in `assets/wordpress-runtime-artifact.json` provenance manifest. The immutable R2 key is derived from the corpus ZIP SHA-256. Cold boot fetches that exact object through `WORDPRESS_STATE_BUCKET`, validates the manifest and archive/file hashes and budgets, then streams it into PHP MEMFS. Static browser assets continue to use lazy exact archive ranges and Worker cache.
 
-Canonical Cloudflare boots materialize a named mu-plugin that removes only core's `wp_cron` `init` callback when the runtime policy defines `DISABLE_WP_CRON` as true. Cron spawning is explicitly disabled by this runtime policy because the PHP-WASM/MDI shutdown callback path is not supported. Update and privacy scheduling callbacks remain registered; an explicit durable cron execution contract is separate future scope.
+Canonical Cloudflare boots patch only the assembled PHP MEMFS copy of `/wordpress/wp-settings.php` after the R2 WordPress corpus is materialized and before WordPress executes. The patch requires exactly one canonical `do_action( 'init' );` needle, fails closed otherwise, removes only core's `wp_cron` callback through public `remove_action()` when `DISABLE_WP_CRON` is true, then executes the original `init` call once. Cron spawning is explicitly disabled by this runtime policy because the PHP-WASM/MDI shutdown callback path is not supported. Update and privacy scheduling callbacks remain registered; an explicit durable cron execution contract is separate future scope.
 
 ## MDI Init Diagnostics
 

packages/runtime-cloudflare/src/worker.ts

@@ -1003,7 +1003,7 @@ async function bootWordPressRuntime(
   siteUrl = SITE_URL,
   authConstants: Partial<Record<WordPressAuthConstant, string>> = {},
   runtimeBucket?: R2Bucket,
-  canonicalCronAdapter = false,
+  shouldPatchCanonicalCronAtInit = false,
 ): Promise<{ php: PHP; requestHandler: PHPRequestHandler; wordpressVersion: string }> {
   const requestHandler = await bootWordPressAndRequestHandler({
     createPhpRuntime,
@@ -1035,7 +1035,7 @@ async function bootWordPressRuntime(
           materializeRuntimeFiles(php, MARKDOWN_ROOT, markdownFiles)
           if (markdownIndexSeed) php.writeFile(MARKDOWN_RESOLVED_INDEX_PATH, markdownIndexSeed)
         }
-        if (canonicalCronAdapter) materializeCanonicalCronAdapter(php)
+        if (shouldPatchCanonicalCronAtInit) patchCanonicalCronAtInit(php)
       } : undefined,
       beforeDatabaseSetup: databaseSeed ? (php: PHP) => {
         php.mkdir("/wordpress/wp-content/database")
@@ -1063,24 +1063,19 @@ function materializeRuntimeFiles(php: PHP, root: string, files: RuntimeFile[]):
   }
 }
 
-function materializeCanonicalCronAdapter(php: PHP): void {
-  const path = "/wordpress/wp-content/mu-plugins/wp-codebox-canonical-cron-policy.php"
-  php.mkdir(path.slice(0, path.lastIndexOf("/")))
-  php.writeFile(path, new TextEncoder().encode(`<?php
-/**
- * Plugin Name: WP Codebox Canonical Cron Policy
- */
-
-if ( defined( 'DISABLE_WP_CRON' ) && DISABLE_WP_CRON ) {
-	add_action(
-		'init',
-		static function (): void {
-			remove_action( 'init', 'wp_cron' );
-		},
-		PHP_INT_MIN
-	);
-}
-`))
+function patchCanonicalCronAtInit(php: PHP): void {
+  const settingsPath = "/wordpress/wp-settings.php"
+  const needle = "do_action( 'init' );"
+  const settings = new TextDecoder().decode(php.readFileAsBuffer(settingsPath))
+  const firstNeedle = settings.indexOf(needle)
+  if (firstNeedle === -1 || firstNeedle !== settings.lastIndexOf(needle)) {
+    throw new Error("WordPress canonical cron patch needle was not uniquely found.")
+  }
+  const replacement = `if ( defined( 'DISABLE_WP_CRON' ) && DISABLE_WP_CRON ) {
+	remove_action( 'init', 'wp_cron' );
+}
+${needle}`
+  php.writeFile(settingsPath, new TextEncoder().encode(`${settings.slice(0, firstNeedle)}${replacement}${settings.slice(firstNeedle + needle.length)}`))
 }
 
 function collectRuntimeFiles(php: PHP, root: string): RuntimeFile[] {

tests/cloudflare-runtime.test.ts

@@ -313,16 +313,22 @@ test("Cloudflare MDI lifecycle diagnostics use the complete packaged seed withou
   assert.match(worker, /function canonicalChangedPathCounts/)
 })
 
-test("Cloudflare canonical runtime materializes a conditional cron policy without removing other scheduling callbacks", async () => {
+test("Cloudflare canonical runtime patches the unique init call in MEMFS without removing other scheduling callbacks", async () => {
   const worker = await readFile(new URL("../packages/runtime-cloudflare/src/worker.ts", import.meta.url), "utf8")
-  const adapter = worker.match(/function materializeCanonicalCronAdapter\(php: PHP\): void \{[\s\S]*?\n\}/)?.[0]
-
-  assert.ok(adapter, "The canonical cron policy materializer is present.")
-  assert.match(adapter, /wp-content\/mu-plugins\/wp-codebox-canonical-cron-policy\.php/)
-  assert.match(adapter, /defined\( 'DISABLE_WP_CRON' \) && DISABLE_WP_CRON/)
-  assert.match(adapter, /add_action\([\s\S]*'init'[\s\S]*remove_action\( 'init', 'wp_cron' \)[\s\S]*PHP_INT_MIN/)
-  assert.doesNotMatch(adapter, /wp_schedule_update_checks|wp_schedule_delete_old_privacy_export_files|\$GLOBALS\['wp_filter'\]/)
-  assert.match(worker, /runtimeBucket\?: R2Bucket,\n  canonicalCronAdapter = false,/)
+  const patcher = worker.slice(worker.indexOf("function patchCanonicalCronAtInit"), worker.indexOf("\nfunction collectRuntimeFiles"))
+
+  assert.ok(patcher.startsWith("function patchCanonicalCronAtInit"), "The canonical cron init patcher is present.")
+  assert.match(patcher, /const settingsPath = "\/wordpress\/wp-settings\.php"/)
+  assert.match(patcher, /php\.readFileAsBuffer\(settingsPath\)/)
+  assert.match(patcher, /firstNeedle === -1 \|\| firstNeedle !== settings\.lastIndexOf\(needle\)/)
+  assert.match(patcher, /throw new Error\("WordPress canonical cron patch needle was not uniquely found\."\)/)
+  assert.match(patcher, /defined\( 'DISABLE_WP_CRON' \) && DISABLE_WP_CRON/)
+  assert.match(patcher, /remove_action\( 'init', 'wp_cron' \)/)
+  assert.equal((patcher.match(/do_action\( 'init' \);/g) ?? []).length, 1)
+  assert.match(patcher, /php\.writeFile\(settingsPath/)
+  assert.doesNotMatch(patcher, /mu-plugins|add_action\(|wp_schedule_update_checks|wp_schedule_delete_old_privacy_export_files|\$GLOBALS\['wp_filter'\]/)
+  assert.doesNotMatch(worker, /materializeCanonicalCronAdapter|wp-codebox-canonical-cron-policy/)
+  assert.match(worker, /runtimeBucket\?: R2Bucket,\n  shouldPatchCanonicalCronAtInit = false,/)
   assert.match(worker, /authConstants, bucket, true\), pointer/)
   assert.match(worker, /env\.WORDPRESS_STATE_BUCKET, true\)/)
   assert.match(worker, /canonical-probe\.invalid", \{\}, bucket, true\)/)