Bound PHPUnit response streams independently

Author: chubes4

packages/runtime-playground/src/wordpress-command-runners.ts

@@ -971,16 +971,21 @@ export async function runPhpunitCommand({
     throw attachPlaygroundDiagnostics(new Error("wordpress.phpunit terminated before completing bootstrap"), "wordpress.phpunit structured diagnostics", structured)
   }
   if (!phpunitArgs.includes("--list-tests") && !/\bOK(?:, but there were issues!)? \([1-9]\d* tests?,/m.test(response.text)) {
-    const diagnostics = [
-      response.errors?.trim() ? `--- stderr ---\n${response.errors.trim()}` : "",
-      response.text.trim() ? `--- stdout ---\n${response.text.trim()}` : "",
-    ].filter(Boolean).join("\n")
+    const diagnostics = successfulPhpunitResponseDiagnostics(response)
     throw attachPlaygroundDiagnostics(new Error("wordpress.phpunit exited successfully without a non-zero PHPUnit test summary"), "wordpress.phpunit successful response diagnostics", diagnostics)
   }
 
   return response.text
 }
 
+function successfulPhpunitResponseDiagnostics(response: PlaygroundRunResponse): string {
+  const boundedStream = (value: string): string => value.length > 9_000 ? `${value.slice(0, 9_000)}\n[stream truncated]` : value
+  return [
+    response.errors?.trim() ? `--- stderr ---\n${boundedStream(response.errors.trim())}` : "",
+    response.text.trim() ? `--- stdout ---\n${boundedStream(response.text.trim())}` : "",
+  ].filter(Boolean).join("\n")
+}
+
 function boundedProcessIdentity(value: string | undefined): string {
   if (!value) return ""
   if (!/^[A-Za-z0-9][A-Za-z0-9._-]*$/.test(value)) throw new Error(`Invalid PHPUnit process identity: ${value}`)

tests/phpunit-runtime-failure-diagnostics.test.ts

@@ -57,7 +57,7 @@ await assert.rejects(
     mounts: [],
     runPlaygroundCommand: async () => ({
       exitCode: 0,
-      errors: `PHPUnit stderr token=${successfulResponseSecret}`,
+      errors: `PHPUnit stderr token=${successfulResponseSecret}\n${"e".repeat(25_000)}`,
       text: `WPCOM Codebox PHPUnit shutdown: mysql_port=unset\n${"x".repeat(25_000)}`,
     }),
     runtimeSpec: { environment: { kind: "wordpress", name: "test", version: "latest" }, policy: { commands: ["wordpress.phpunit"] } } as never,
@@ -71,9 +71,9 @@ await assert.rejects(
     assert.match(error.message, /--- stdout ---/)
     assert.match(error.message, /WPCOM Codebox \[redacted\] shutdown: mysql_port=unset/)
     assert.match(error.message, /PHPUnit stderr token=\[redacted\]/)
-    assert.match(error.message, /\[diagnostic truncated\]/)
+    assert.match(error.message, /\[stream truncated\]/)
     assert.doesNotMatch(error.message, new RegExp(successfulResponseSecret))
-    assert.ok(error.message.length < 21_000, "successful response diagnostics must remain bounded")
+    assert.ok(error.message.length < 19_000, "successful response diagnostics must remain bounded")
     return true
   },
 )