Preserve browser runtime versions during post-runtime composition (#1802)

Author: chubes4

packages/wordpress-plugin/src/trait-wp-codebox-abilities-browser-blueprint.php

@@ -56,6 +56,11 @@ private static function browser_blueprint_with_post_runtime( array $blueprint, a
 	$post_steps = is_array( $post_runtime_blueprint['steps'] ?? null ) ? $post_runtime_blueprint['steps'] : array();
 	$merged     = array_merge( $blueprint, $post_runtime_blueprint );
 	$merged['steps'] = array_values( array_merge( $steps, $post_steps ) );
+	if ( array_key_exists( 'preferredVersions', $blueprint ) ) {
+		$merged['preferredVersions'] = $blueprint['preferredVersions'];
+	} else {
+		unset( $merged['preferredVersions'] );
+	}
 
 	if ( isset( $blueprint['features'] ) && isset( $post_runtime_blueprint['features'] ) && is_array( $blueprint['features'] ) && is_array( $post_runtime_blueprint['features'] ) ) {
 		$merged['features'] = array_merge( $blueprint['features'], $post_runtime_blueprint['features'] );

scripts/php-browser-post-runtime-blueprint-smoke.php

@@ -15,16 +15,17 @@ public static function merge( array $blueprint, array $post_runtime ): array {
 }
 
 $runtime_blueprint = array(
-	'preferredVersions' => array( 'php' => '8.3' ),
+	'preferredVersions' => array( 'wp' => '7.0', 'php' => '8.4' ),
 	'features'          => array( 'networking' => false ),
 	'steps'             => array(
 		array( 'step' => 'login' ),
 		array( 'step' => 'installPlugin', 'pluginData' => array( 'url' => 'runtime.zip' ) ),
 	),
 );
 $post_runtime = array(
-	'features' => array( 'networking' => true ),
-	'steps'    => array( array( 'step' => 'runPHP', 'code' => '<?php import_site();' ) ),
+	'preferredVersions' => array( 'wp' => 'latest', 'php' => '8.2' ),
+	'features'          => array( 'networking' => true ),
+	'steps'             => array( array( 'step' => 'runPHP', 'code' => '<?php import_site();' ) ),
 );
 
 $merged = WP_Codebox_Post_Runtime_Blueprint_Smoke::merge( $runtime_blueprint, $post_runtime );
@@ -34,6 +35,10 @@ public static function merge( array $blueprint, array $post_runtime ): array {
 	fwrite( STDERR, 'Post-runtime blueprint steps were not appended after runtime materialization.' . PHP_EOL );
 	exit( 1 );
 }
+if ( array( 'wp' => '7.0', 'php' => '8.4' ) !== ( $merged['preferredVersions'] ?? null ) ) {
+	fwrite( STDERR, 'Post-runtime blueprint preferredVersions overwrote the runtime selection.' . PHP_EOL );
+	exit( 1 );
+}
 if ( true !== ( $merged['features']['networking'] ?? null ) ) {
 	fwrite( STDERR, 'Post-runtime blueprint features did not override the base feature.' . PHP_EOL );
 	exit( 1 );