Preserve PHPUnit paths and harness intent#1826
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testRootandphpunitXmlthrough therecipe build phpunitCLI boundaryautoload-filevalues explicitly as PHPUnit harness autoloadersFixes #1820.
Fixes #1821.
Why
A real mounted WPCOM PHPUnit recipe exposed two separate boundaries. The CLI dropped the configured test root and XML path, then the project-mode handler inferred autoload semantics from the literal
/wp-codebox-vendor/autoload.phppath. Canonical staging legitimately changes that path, causing the handler to misclassify the harness as a legacy project autoloader.The explicit
autoload-file-role=harnesscontract keeps semantic intent independent of path rewriting.How to test
npm install.npx tsx tests/phpunit-project-autoload.test.ts.npm run test:runtime-services.npm run build./tmp/wp-codebox-inputs/.../autoload.phppath as the harness.autoload-file-roleretain the legacy project-autoload behavior.Runtime evidence
A full WPCOM
core/actionsrecipe with mounted inputs and disposable MySQL progressed past harness readability and WPCOM polyfill bootstrap after this change. The next independent blocker is missing PHP Sodium capability, tracked in #1825.AI assistance