Fix trusted runner workspace patch application#1839
Merged
Conversation
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1837
Summary
Source Evidence And Scope
MODEL_PROVIDER_SECRET_1=OPENAI_API_KEY; that value is unchanged diff context, so redacting the apply input makesgit applyfail while the trusted snapshot succeeds. It also asserts the durable patch and uploaded apply-failure patch are redacted.codebox-patchandcodebox-changed-filesrefs are copied, each remains a bounded regular file, andapplyRunnerWorkspacePatchstill performs its existing digest, path, seed identity, changed-file, and post-apply integrity checks.Compatibility Impact
No public API or artifact schema changes. Runner workspace application behavior is unchanged except it now remains applicable when a configured secret value occurs in unchanged patch context. Durable artifacts are more strictly redacted.
Fresh Checkout Verification
git clone https://github.com/Automattic/wp-codebox.git && cd wp-codeboxnpm ciTMPDIR=/tmp npm run test:runner-workspace-applyTMPDIR=/tmp npm run test:redactionnpm run test:native-agent-task-lifecycleTMPDIR=/tmp npm run buildTMPDIR=/tmpkeeps tsx IPC socket paths below the platform limit in deeply nested checkout paths.Validation
TMPDIR=/tmp npm run test:runner-workspace-applyTMPDIR=/tmp npm run test:redactionnpm run test:native-agent-task-lifecycleTMPDIR=/tmp npm run buildRelease Notes
CHANGELOG.mdis intentionally unchanged; release automation generates it.AI Assistance
GPT-5.6 assisted with codebase tracing, the temporary-artifact primitive, and regression-test drafting. The resulting diff and focused commands were reviewed and executed in this checkout.