Fix staged binary assets in browser previews - #1939
Merged
Merged
Conversation
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
materializePlaygroundStagedInputs()writes staged binary bytes through the primary PHP instance. The programmatic request handler previously allowed secondary PHP instances for browser HTTP requests; those instances did not receive post-boot VFS writes, so staged HTML/CSS could load while PNG/JPEG assets failed.Setting
maxPhpInstances: 1makes runtime setup, staged input materialization, and browser preview requests share one coherent filesystem.Closes #1935.
Verification
npm run buildnpm run test:playground-staged-upload-previewnpx tsx tests/staged-input-materialization.test.tsnpm run test:browser-visual-compare-capture-reliabilitynpm run test:playground-readonly-mounts-integrationnpm run test:playground-staged-upload-previewFocused Fisiostetic Lab rerun with this branch:
837041/7036160), improved from 19.58% (1377921/7036160) without Blocks Engine or SSI changesThe remaining mismatch is real source/candidate geometry rather than missing source assets.
AI assistance