fix: force fresh dist for release packages - #2000
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mount-materialization.jsbefore packaging to prove release assembly replaces stale distRoot cause
The installed CLI reported the current package version because
--versionreadspackages/cli/package.json, while its ignored compileddistcould predate the source changes from #1797. Release assembly called the ordinary incrementaltsc -b; when.tsbuildinfoconsidered the project current, TypeScript could leave a stale or externally replaced dist file untouched and package it under current metadata.The source protection from #1797 was therefore insufficient at the release boundary:
stageReadonlyPlaygroundMountsand the invalid-UTF-8 base64 fallback were correct in source, but package startup/version checks did not prove those behaviors existed in the shipped JavaScript.Regression coverage
tests/release-package-coverage.test.tsnow:Verification
npm run test:playground-readonly-mountspassednpx tsx tests/mount-materialization.test.tspassednpm run buildpassednpm run test:playground-readonly-mounts-integrationpassednpm run test:release-package-coveragepassedgit diff --checkpassedFixes #1998.
No release, deploy, or merge was performed.