Copy over nonce from parsed POST vars to parsed GET vars as a temp fix#36
Merged
Conversation
Currently bshaffer oauth library has a bug when POST is used on AuthorizeEndpoint along with nonce (optional parameter) which fails to set the nonce in id_token
psrpinto
reviewed
Sep 21, 2022
psrpinto
left a comment
psrpinto
left a comment
Member
There was a problem hiding this comment.
Thanks for also opening a PR to the library!
Member
|
Could we also work around the library issue by just doing a |
…ers in $request object as a temporary fix
Member
Author
Member
Author
|
@akirk Going to merge this but happy to address any remarks, if there are any, later on. |
ashfame
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently bshaffer oauth library has a bug when POST is used on AuthorizeEndpoint along with nonce (optional parameter) which fails to set the nonce in id_token
This PR switches the form submit method to
GETwhen taking user consent and this fixes the issue.Fixes #35
The reason why this issue would only break for new users is because of sticky consent functionality the parameters would get passed as GET parameters, hence not uncovering the issue with bshaffer oauth library.
Additionally, I have also already created a PR to the library with the fix.