Phan: Address PhanRedundantCondition, PhanRedundantArrayValuesCall, and PhanPluginRedundantAssignment violations (#45681)

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/18973127629

Upstream-Ref: Automattic/jetpack@4a37fb5

Author: tbradsha

CHANGELOG.md

@@ -15,6 +15,9 @@ This is an alpha version! The changes listed here are not final.
 ### Changed
 - Update package dependencies.
 
+### Fixed
+- Phan: Address PhanRedundantCondition, PhanRedundantArrayValuesCall, and PhanPluginRedundantAssignment violations.
+
 ## [3.0.2] - 2025-10-10
 ### Added
 - Add typecheck support for E2E tests. [#44788]

rest/class.wp-super-cache-rest-update-settings.php

@@ -216,7 +216,6 @@ protected function set_super_cache_enabled( $value ) {
 				add_mod_rewrite_rules();
 
 			} elseif( $value == 2 ) { // PHP
-				$wp_cache_mod_rewrite = 0;
 				remove_mod_rewrite_rules();
 
 			}

wp-cache-phase2.php

@@ -2508,7 +2508,6 @@ function wp_cache_get_ob( &$buffer ) {
 		}
 	}
 
-	$new_cache = true;
 	if ( $fr ) {
 		$supercacheonly = false;
 		fclose( $fr );
@@ -2911,7 +2910,6 @@ function wp_cache_shutdown_callback() {
 						$value = 'application/rss+xml';
 				}
 			}
-			$is_feed = true;
 
 			if ( isset( $wpsc_feed_ttl ) && $wpsc_feed_ttl == 1 ) {
 				$wp_cache_meta['ttl'] = 60;

wp-cache.php

@@ -744,7 +744,7 @@ function wp_cache_manager_updates() {
 		return false;
 
 	if ( false == isset( $cache_page_secret ) ) {
-		$cache_page_secret = md5( (string) ( gmdate( 'H:i:s' ) . wp_rand() ) );
+		$cache_page_secret = md5( gmdate( 'H:i:s' ) . wp_rand() );
 		wp_cache_replace_line('^ *\$cache_page_secret', "\$cache_page_secret = '" . $cache_page_secret . "';", $wp_cache_config_file);
 	}
 
@@ -2990,7 +2990,7 @@ function wp_cache_admin_notice() {
 function wp_cache_check_site() {
 	global $wp_super_cache_front_page_check, $wp_super_cache_front_page_clear, $wp_super_cache_front_page_text, $wp_super_cache_front_page_notification, $wpdb;
 
-	if ( !isset( $wp_super_cache_front_page_check ) || ( isset( $wp_super_cache_front_page_check ) && $wp_super_cache_front_page_check == 0 ) ) {
+	if ( empty( $wp_super_cache_front_page_check ) ) {
 		return false;
 	}