Skip to content

Fix CI: multi-PHP testing and PHPCS linting#1020

Merged
kraftbj merged 4 commits into
trunkfrom
test/ci-check-trunk
Apr 7, 2026
Merged

Fix CI: multi-PHP testing and PHPCS linting#1020
kraftbj merged 4 commits into
trunkfrom
test/ci-check-trunk

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Apr 7, 2026

Summary

  • Merge trunk to pick up the monorepo separation commit
  • Add phpunit.11.xml.dist and phpunit.12.xml.dist so phpunit-select-config finds the right config for each PHPUnit major version
  • Update php-tests.yml to fall back to composer update when composer.lock is incompatible with the PHP version under test (e.g. PHP 8.2 needs PHPUnit 11, but lock pins PHPUnit 12)
  • Switch linting.yml from full phpcs to phpcs-changed, which only reports new violations on changed lines — avoids failing on pre-existing issues in untouched files
  • Add sirbrillig/phpcs-changed as a dev dependency

Test plan

  • PHPUnit passes on PHP 8.2, 8.3, 8.4, 8.5
  • PHPCS passes on PRs that don't introduce new violations
  • Changelogger continues to pass

@kraftbj kraftbj changed the title Test: exercise CI on trunk Fix CI: multi-PHP testing and PHPCS linting Apr 7, 2026
@kraftbj kraftbj marked this pull request as ready for review April 7, 2026 21:51
@kraftbj kraftbj merged commit 1949454 into trunk Apr 7, 2026
1 of 6 checks passed
@kraftbj kraftbj deleted the test/ci-check-trunk branch April 7, 2026 21:57
kraftbj added a commit that referenced this pull request Apr 7, 2026
* test: bump minimum PHP to 7.4 to exercise CI

* fix: support multi-PHP testing in CI

* fix: use phpcs-changed to lint only modified lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant