Skip to content

Fix: hide debug HTML comments in REST and Ajax responses #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donnchawp merged 4 commits into from
May 27, 2026
Merged

Fix: hide debug HTML comments in REST and Ajax responses #1021

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18753eb
fix: hide debug HTML comments in REST and Ajax responses
jom Apr 7, 2026
b86fa97
fix: clarify debug comment suppression messages
kraftbj Apr 7, 2026
2ac3825
Extract wpsc_skip_debug_output() to de-duplicate the non-HTML respons…
donnchawp May 27, 2026
737ffb9
Also skip debug comments on XML-RPC requests
donnchawp May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions wp-cache-phase2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2191,6 +2191,15 @@ function wp_cache_ob_callback( $buffer ) {
}
}

function wpsc_skip_debug_output( $buffer ) {
return strpos( $buffer, '<html' ) === false ||
( defined( 'REST_REQUEST' ) && REST_REQUEST ) ||
( defined( 'JSON_REQUEST' ) && JSON_REQUEST ) ||
( defined( 'WC_API_REQUEST' ) && WC_API_REQUEST ) ||
( defined( 'XMLRPC_REQUEST' ) && XMLRPC_REQUEST ) ||
( function_exists( 'wp_doing_ajax' ) && wp_doing_ajax() );
}

function wp_cache_append_tag( &$buffer ) {
global $wp_cache_gmt_offset, $wp_super_cache_comments;
global $cache_enabled, $super_cache_enabled;
Expand All @@ -2210,7 +2219,7 @@ function wp_cache_append_tag( &$buffer ) {
$msg = "Live page served on $timestamp";
}

if ( strpos( $buffer, '<html' ) === false ) {
if ( wpsc_skip_debug_output( $buffer ) ) {
wp_cache_debug( site_url( $_SERVER['REQUEST_URI'] ) . ' - ' . $msg );
return false;
}
Expand All @@ -2229,7 +2238,7 @@ function wp_cache_add_to_buffer( &$buffer, $text ) {
return false;
}

if ( strpos( $buffer, '<html' ) === false ) {
if ( wpsc_skip_debug_output( $buffer ) ) {
wp_cache_debug( site_url( $_SERVER['REQUEST_URI'] ) . ' - ' . $text );
return false;
}
Expand Down
Loading