Tidy debug call in wp_cache_get_postid_from_comment()#1052
Merged
Conversation
phpcs (changed-lines) flagged the double-quoted string added in #1043; it has no interpolation, so single quotes are correct.
wp_cache_debug()'s $level parameter (line 722) is declared but never used in the function body. Remove the unused '4' argument from this call.
donnchawp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small cleanups to the
wp_cache_debug()call added in #1043:wp_cache_debug( $message, $level = 1 )declares$levelbut never uses it in the function body, so the trailing4did nothing.Net:
wp_cache_debug( 'Comment not found; skipping cache update.' );