Skip to content

Feature/button hri#1

Open
shaolink8 wants to merge 9 commits into
prodfrom
feature/button_hri
Open

Feature/button hri#1
shaolink8 wants to merge 9 commits into
prodfrom
feature/button_hri

Conversation

@shaolink8

Copy link
Copy Markdown

pls review

class FirebaseNode:
def __init__(self, schema, operation_mode_callback, teleop_mode_callback):
firebase_secrets_path = os.path.expanduser("~/ws/api_keys/firebase_secrets.json")
firebase_secrets_path = os.path.expanduser("~/firebasesecrets.json")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets standardize this and make it ".firebase_secrets.json"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the file resides as .alfred-auxilio-firebase-adminsdk.json on both our robots

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organize this into correct directory (separate backup directory)


self.last_update = time.time()

self.bot_state = BotStateManager(self.stateUpdateCallback)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

botstatemanager and firebase have to somehow be merged to ensure teleop runs smoothly. architecture to be discussed

'fetch_banana' : [LocationOfInterest.LIVING_ROOM, ObjectOfInterest.BANANA],
}

self.navigationGoal = None

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigation goal to be made more modular and easily updatable since there will be several rooms in the facility

self.bot_state.update_state()
self.bot_state.currentGlobalState = GlobalStates.REACHED_GOAL
rospy.loginfo(f"[{rospy.get_name()}]:" +"Reached {}".format(locationName))
rospy.loginfo(f"[{rospy.get_name()}]:" +"Reached Table")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be better to keep this modular so that we can have accurate logs instead of hardcoding

Comment on lines +50 to +52
#define API_KEY "AIzaSyCOGooVhBRo-IXpRi5E96KUFQekYXEGfpg"

#define DATABASE_URL "https://alfred-auxilio-default-rtdb.firebaseio.com/" //<databaseName>.firebaseio.com or <databaseName>.<region>.firebasedatabase.app

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define API_KEY "AIzaSyCOGooVhBRo-IXpRi5E96KUFQekYXEGfpg"
#define DATABASE_URL "https://alfred-auxilio-default-rtdb.firebaseio.com/" //<databaseName>.firebaseio.com or <databaseName>.<region>.firebasedatabase.app

API key present

class FirebaseNode:
def __init__(self, schema, operation_mode_callback, teleop_mode_callback):
firebase_secrets_path = os.path.expanduser("~/ws/api_keys/firebase_secrets.json")
firebase_secrets_path = os.path.expanduser("~/firebasesecrets.json")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the file resides as .alfred-auxilio-firebase-adminsdk.json on both our robots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants