Skip to content

Commit a7a76c5

Browse files
authored
Merge pull request #158 from AvaCodeSolutions/fix/157/quiz-submission-events-bug
fix: #157 fix quiz submission event for seconds attempt
2 parents e893c6f + 497876d commit a7a76c5

3 files changed

Lines changed: 21 additions & 21 deletions

File tree

django_email_learning/platform/api/serializers.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,8 +471,13 @@ def from_django_model(enrollment: Enrollment) -> "EnrollmentResponse":
471471
quiz_attempts = delivery.quiz_submissions.all().order_by(
472472
"submitted_at"
473473
)
474-
for attempt in quiz_attempts:
475-
attempt_number += 1
474+
if not schedule.failed_attempts:
475+
attempt = quiz_attempts.first()
476+
attempt_number = 1
477+
else:
478+
attempt_number = schedule.failed_attempts + 1
479+
attempt = quiz_attempts[attempt_number - 1 : 1].first()
480+
if attempt:
476481
events.append(
477482
Event(
478483
type=EventType.QUIZ_SUBMITED,

frontend/package-lock.json

Lines changed: 11 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/platform/learners/Learners.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ function Learners(initialQs="") {
119119
{ event.type === "content_sent" && <>
120120
<Box><Typography>{event.event_data.course_content_title}</Typography></Box>
121121
</>}
122+
{ event.type === "deactivated" && <>
123+
<Box><Typography>Reason: {event.event_data.reason}</Typography></Box>
124+
</>}
122125
</TimelineContent>
123126
</TimelineItem>
124127
))}

0 commit comments

Comments
 (0)