fix: widen cryptography upper bound to major version#520
Closed
gavin913-lss wants to merge 1 commit into
Closed
Conversation
Patch-level pin (>=48.0.0,<48.1.0) causes dependency conflicts for any integrator that already has cryptography>=48.1.0. Widen to >=48.0.0,<49.0.0 following the standard pattern. Fixes AvaCodeSolutions#500
Contributor
|
Thank you @gavin913-lss, the pipeline failed and it seems that poetry lock should be updated as well. |
Contributor
|
Will be handled here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyproject.tomloriginally pinnedcryptographyat patch level (<48.1.0), and was previously updated to<49.0.0. Howevercryptography 49.0.0has now been released, causing the same install conflict for anyone with a newer environment.Fixes #500
Fix
Widen the constraint to
>=48.0.0,<50.0.0— a full major-version range following standard open-source library practice. This means the pin only needs updating ifcryptographyships a breaking change in a new major version, rather than on every minor/patch release.Note
The branch has been rebased onto master and the constraint updated to
<50.0.0since the original<49.0.0is now also stale.